Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 Missing colors when rome is spawned from node #3623

Closed
1 task done
yavorski opened this issue Nov 9, 2022 · 0 comments · Fixed by #3625
Closed
1 task done

🐛 Missing colors when rome is spawned from node #3623

yavorski opened this issue Nov 9, 2022 · 0 comments · Fixed by #3625
Assignees
Labels
A-CLI Area: CLI enhancement New feature request or improvement to existing functionality Help wanted Help would be really appreciated

Comments

@yavorski
Copy link

yavorski commented Nov 9, 2022

Environment information

𝝺 rome rage
CLI:
  Version:              10.0.0
  Color support:        true

Platform:
  CPU Architecture:     x86_64
  OS:                   linux

Environment:
  ROME_LOG_DIR:         unset
  NO_COLOR:             unset
  TERM:                 "alacritty"

Rome Configuration:
  Status:               loaded
  Formatter disabled:   false
  Linter disabled:      false

Workspace:
  Open Documents:       0

Discovering running Rome servers...

Server:
  Status:               stopped

What happened?

Colors are missing when rome is spawned:

import { exec } from 'child_process';
export async function lint() {
  const rome = "npx rome check ./src/js/**";
  return new Promise((resolve, reject) => {
    exec(rome, (error, stdout, stderr) => {
      if (error) {
        console.error(error);
        reject(error);
      }
      console.log(stdout, stderr);
      resolve();
    });
  });
}

Here is a link to discord conversation https://discordapp.com/channels/678763474494423051/1039887487167901757

Expected result

Should have colors : )
Thank you!

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@yavorski yavorski added the S-To triage Status: user report of a possible bug that needs to be triaged label Nov 9, 2022
@MichaReiser MichaReiser added enhancement New feature request or improvement to existing functionality Help wanted Help would be really appreciated A-CLI Area: CLI and removed S-To triage Status: user report of a possible bug that needs to be triaged labels Nov 9, 2022
@leops leops self-assigned this Nov 9, 2022
@yavorski yavorski changed the title 🐛 Missing colors, when rome is spawned from node 🐛 Missing colors when rome is spawned from node Nov 9, 2022
@leops leops modified the milestones: 10.0.1, 11.0.0 Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-CLI Area: CLI enhancement New feature request or improvement to existing functionality Help wanted Help would be really appreciated
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants