Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outputReady hook not firing #28

Open
botandrose opened this issue Dec 15, 2015 · 3 comments
Open

outputReady hook not firing #28

botandrose opened this issue Dec 15, 2015 · 3 comments

Comments

@botandrose
Copy link

Heya heya, I'm getting an infinite loop in Ember-Cli-Rails when building the app, and I've tracked it down to the outputReady hook in this addon not firing. Don't have any hypotheses, at the moment. Here is the output log, if it helps.

Future versions of Ember CLI will not support v0.10.25. Please update to Node 0.12 or io.js.
version: 1.13.8
Could not find watchman, falling back to NodeWatcher for file system events.
Visit http://www.ember-cli.com/user-guide/#watchman for more info.
BuildingBuilding.Building..Building...BuildingBuilding...

Build successful - 1976ms.

Slowest Trees                                 | Total               
----------------------------------------------+---------------------
ES6: App Tree                                 | 530ms               
TemplateCompiler                              | 275ms               
TemplateCompiler                              | 244ms               
CoffeeScriptFilter                            | 240ms               

Slowest Trees (cumulative)                    | Total (avg)         
----------------------------------------------+---------------------
TemplateCompiler (3)                          | 537ms (179 ms)      
ES6: App Tree (1)                             | 530ms               
CoffeeScriptFilter (2)                        | 241ms (120 ms)      
@rwjblue
Copy link
Collaborator

rwjblue commented Dec 16, 2015

You should try updating to the latest 1.13 version of ember-cli, I do not believe that 1.13.8 includes that hook.

This addon could detect ember-cli version and use the appropriate hook.

Robert Jackson

-- twitter: rwjblue
-- github: rjackson

@botandrose
Copy link
Author

Yes, thank you, @rwjblue, you are correct! Looks like outputReady was added in 1.13.12. Another possible solution could be changing this addon to depend on that version at minimum.

@rwjblue
Copy link
Collaborator

rwjblue commented Dec 17, 2015

Yep, either work. But one or the other should be done.

For anyone willing to do the work, using ember-cli-version-checker and dep.isAbove('1.13.11') should do the trick...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants