From 700df51f96cc7d29fc3940dbdb3d85a8a7b19127 Mon Sep 17 00:00:00 2001 From: subhamkrai Date: Wed, 11 Sep 2024 11:08:27 +0530 Subject: [PATCH 1/2] mons: restore-quorum should procced with probing currently, mon restore-quorum fails if mon status is not in leader or peon but it should also include probing state as when majority of the mons down mons goes to probing state until it finds the other mons. Signed-off-by: subhamkrai --- pkg/mons/restore_quorum.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/mons/restore_quorum.go b/pkg/mons/restore_quorum.go index f60d8dd9..edce606d 100644 --- a/pkg/mons/restore_quorum.go +++ b/pkg/mons/restore_quorum.go @@ -327,7 +327,7 @@ func validateMonIsUp(ctx context.Context, clientsets *k8sutil.Clientsets, cluste logging.Info("mon %q state is %q", monID, monStatusOut.State) - if monStatusOut.State == "leader" || monStatusOut.State == "peon" { + if monStatusOut.State == "leader" || monStatusOut.State == "peon" || monStatusOut.State == "probing" { return nil } From 5d1c2b8322b0a045ce6a1910a34d6050c81396ce Mon Sep 17 00:00:00 2001 From: subhamkrai Date: Wed, 11 Sep 2024 16:04:38 +0530 Subject: [PATCH 2/2] ci: update upload-artifact version upload-artifact version v2 is depricated, we need to update to latest version Signed-off-by: subhamkrai --- .github/workflows/collect-logs/action.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/collect-logs/action.yaml b/.github/workflows/collect-logs/action.yaml index 75a957d7..56bf7c2d 100644 --- a/.github/workflows/collect-logs/action.yaml +++ b/.github/workflows/collect-logs/action.yaml @@ -15,7 +15,7 @@ runs: tests/collect-logs.sh - name: Upload canary test result - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v4 with: name: ${{ inputs.name }} path: test