-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When running npm start
*.scss
or *.css
file changes cause browser-sync to reloads the page instead of injecting the css changes.
#1713
Comments
I guess this is not really a bug, just a different configuration, since the |
I have the HMR working with the older implementation using I guess I'm wondering why the HMR feature was removed? |
It wasn't deliberate. I thought I had tested it out with the webpack browsersync plugin and determined that the plugin was injecting the changes without reloading, effectively doing the same thing that we were doing in alpha 1. But I must've had some wires crossed or something since obviously that's not the case. I'll get this fixed before the next alpha release. |
This fixed in the master branch. New alpha version will be tagged soon. |
Hi all, Don't want to open a new Issue but I'm still having the same problem after merging the master in my setup. The problem is like @geschwendt said. It opens the page with BS connected, it's rebuilding when I save a CSS or JS file but it does not inject the code in page. I've also tried to add
The page is refreshed but again no css/js is injected. Will keep posting if I find anything on this. Cheers |
@QWp6t any thoughts on this? I can't really manage to find the issue. Thanks |
@geschwendt I had a similar issue where HMR was connected and was injecting changes but with each change the browser was reloading as well. By default, BrowserSync is injecting changes only when css or image file changes. With php, html and js files it triggers a full page reload. To change that just add here this: |
Submit a feature request or bug report
What is the current behavior?
When running
npm start
any asset change (css, js, scss) results in a browser-sync full page refresh.What is the expected or desired behavior?
When running
npm start
any css/scss changes should be injected instead of a full page refresh.This stopped working in version 9.0.0-alpha.2 when the
npm watch
workflow was removed.The text was updated successfully, but these errors were encountered: