Enable jQuery noConflict

[retlehs]

this enables jQuery.noConflict(); just like WP does ¯_(ツ)_/¯

ref #155

[timcv]

Would it be possible to make this optional? We are using soil on alot of sites and the update craches our js.

Kind regards

Tim

[retlehs]

what does "crashes our js" mean exactly

Sent from my iPhone

On Sep 21, 2016, at 12:54 AM, Tim Samuelsson notifications@github.com wrote:

Would it be possible to make this optional? We are using soil on alot of sites and the update craches our js.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

[timcv]

All our js is written without the no conflict mode witch mean that it wount work because we use $ everywhere.

[retlehs]

So you wrote your JavaScript in a way that it shouldn't have been written. Fix your JS or use a previous version of the plugin.

Sent from my iPhone

On Sep 21, 2016, at 8:34 AM, Tim Samuelsson notifications@github.com wrote:

All our js is written without the no conflict mode witch mean that it wount work because we use $ everywhere.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

[timcv]

Hi,

Sorry for a late answer.
Could you explain to me why its wrong to use jQuery without the no conflict mode.

I would be super happy if this could be a setting like define('ROOTS_JQUERY_FALLBACK_NO_CONFLICT, false) or similar.

//Tim

[QWp6t]

WordPress by default uses .noConflict(). We're maintaining parity.

It's trivial to fix your script. Just wrap it in an IIFE.

;(function($) {
  // $() can be used in here...
})(jQuery);

[timcv]

Thanks, would it work if i wrap my hole js build with that in my gulp job?