Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please correct before 2021-05-15 to safely retain your package on CRAN. #310

Closed
cboettig opened this issue May 3, 2021 · 5 comments
Closed

Comments

@cboettig
Copy link
Member

cboettig commented May 3, 2021

Dear maintainer,

Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_codemetar.html.

Please correct before 2021-05-15 to safely retain your package on CRAN.

It seems we need to remind you of the CRAN policy:

'Packages which use Internet resources should fail gracefully with an informative message
if the resource is not available or has changed (and not give a check warning nor error).'

This needs correction whether or not the resource recovers.

The CRAN Team

See https://www.r-project.org/nosvn/R.check/r-patched-solaris-x86/codemetar-00check.html

@maelle
Copy link
Member

maelle commented May 3, 2021

one more test to skip on CRAN then?

Related #286

@cboettig
Copy link
Member Author

cboettig commented May 5, 2021

yup. do you have a moment for a quick PR?

@maelle
Copy link
Member

maelle commented May 7, 2021

not before next week, sorry.

@maelle
Copy link
Member

maelle commented May 10, 2021

Changes I made

  • documenting the breaking changes of write_codemeta()
  • converting tests to testthat third edition to be able to use snapshot tests (removed all occurrences of deprecated context(), converted expect_is() to expect_type()/expect_s3_clqass()).
  • modified the tests for write_codemeta() to actually make them tests for create_codemeta(), with a snapshot
  • added a snapshot test for write_codemeta()
  • skipped all online tests, checked via turning wifi off. All tests that are skipped on CRAN are skipped if offline.

What's needed

@maelle
Copy link
Member

maelle commented May 10, 2021

checklist in #311

@maelle maelle closed this as completed May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants