Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mocking for async methods #78

Open
sckott opened this issue May 16, 2018 · 5 comments
Open

Support mocking for async methods #78

sckott opened this issue May 16, 2018 · 5 comments

Comments

@sckott
Copy link
Collaborator

sckott commented May 16, 2018

Right now, mocking is only supported for HttpClient. Support it for if possible

  • Async
  • AsyncVaried

AsyncVaried is used inside of Async, so should just need to adjust AsyncVaried

@sckott sckott added the mocking label May 16, 2018
@sckott sckott added this to the v0.8 milestone Feb 9, 2019
@sckott
Copy link
Collaborator Author

sckott commented Feb 9, 2019

see local branch mock-async

It's not clear how to do this.

I can't see a way to mock the mutli curl api, but maybe it can be dumber than that ...

@sckott sckott removed this from the v0.8 milestone Feb 9, 2019
@maelle
Copy link
Member

maelle commented Feb 26, 2020

ah, so is this a limit for http testing at the moment?

@sckott
Copy link
Collaborator Author

sckott commented Feb 26, 2020

yes, right now async requests can't be tested with webmockr or vcr

@maelle
Copy link
Member

maelle commented Feb 26, 2020

Good to know!

@maelle
Copy link
Member

maelle commented Mar 24, 2020

so just as a note, in ropenaq tests that uses async requests got skip_if_offline() :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants