Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

target remains outdated if .id does not start with a character #1147

Closed
matthiasgomolka opened this issue Jan 24, 2020 · 6 comments
Closed

target remains outdated if .id does not start with a character #1147

matthiasgomolka opened this issue Jan 24, 2020 · 6 comments
Assignees
@wlandau
Labels
type: edge case

Comments

@matthiasgomolka
Copy link
Contributor

matthiasgomolka commented Jan 24, 2020 •
edited by wlandau
Loading

Description

When I create symbols for the .id argument within map() which do not start with a character, the respective target remains outdated after a successful make(). This seems to occur whenever the created symbols are shown surrounded by . For example, when the symbol starts with an underscore. Also, in the target's name, the get replaced by .s.

Reproducible example

library(drake)

n <- 1:2
ids = rlang::syms(as.character(n))
ids
#> [[1]]
#> `1`
#> 
#> [[2]]
#> `2`

plan <- drake_plan(
    numeric_ids = target(
        rnorm(n),
        transform = map(n = !!n,
                        ids = !!ids,
                        .id = ids)
    )
)
plan
#> # A tibble: 2 x 2
#>   target          command  
#>   <chr>           <expr>   
#> 1 numeric_ids_.1. rnorm(1L)
#> 2 numeric_ids_.2. rnorm(2L)

# first run
vis_drake_graph(drake_config(plan))
make(plan)
#> target numeric_ids_.2.
#> target numeric_ids_.1.

# second run / targets are outdated even though make(plan) ran without errors
vis_drake_graph(drake_config(plan))
make(plan)
#> target numeric_ids_.2.
#> target numeric_ids_.1.

Created on 2020-01-24 by the reprex package (v0.3.0)

Session info 
devtools::session_info()
#> - Session info ---------------------------------------------------------------
#>  setting  value                       
#>  version  R version 3.6.1 (2019-07-05)
#>  os       Windows 10 x64              
#>  system   x86_64, mingw32             
#>  ui       RTerm                       
#>  language (EN)                        
#>  collate  German_Germany.1252         
#>  ctype    German_Germany.1252         
#>  tz       Europe/Berlin               
#>  date     2020-01-24                  
#> 
#> - Packages -------------------------------------------------------------------
#>  package     * version date       lib source        
#>  assertthat    0.2.1   2019-03-21 [1] CRAN (R 3.5.3)
#>  backports     1.1.5   2019-10-02 [1] CRAN (R 3.5.3)
#>  base64url     1.4     2018-05-14 [1] CRAN (R 3.5.3)
#>  callr         3.3.2   2019-09-22 [1] CRAN (R 3.5.3)
#>  cli           1.1.0   2019-03-19 [1] CRAN (R 3.5.3)
#>  crayon        1.3.4   2017-09-16 [1] CRAN (R 3.5.3)
#>  desc          1.2.0   2018-05-01 [1] CRAN (R 3.5.3)
#>  devtools      2.0.2   2019-04-08 [1] CRAN (R 3.5.3)
#>  digest        0.6.22  2019-10-21 [1] CRAN (R 3.5.3)
#>  drake       * 7.9.0   2020-01-08 [1] CRAN (R 3.5.3)
#>  evaluate      0.14    2019-05-28 [1] CRAN (R 3.5.3)
#>  fansi         0.4.0   2018-10-05 [1] CRAN (R 3.5.3)
#>  filelock      1.0.2   2018-10-05 [1] CRAN (R 3.5.3)
#>  fs            1.3.1   2019-05-06 [1] CRAN (R 3.5.3)
#>  glue          1.3.1   2019-03-12 [1] CRAN (R 3.5.3)
#>  highr         0.8     2019-03-20 [1] CRAN (R 3.5.3)
#>  htmltools     0.4.0   2019-10-04 [1] CRAN (R 3.5.3)
#>  igraph        1.2.4.1 2019-04-22 [1] CRAN (R 3.5.3)
#>  knitr         1.26    2019-11-12 [1] CRAN (R 3.5.3)
#>  magrittr      1.5     2014-11-22 [1] CRAN (R 3.5.3)
#>  memoise       1.1.0   2017-04-21 [1] CRAN (R 3.5.3)
#>  pillar        1.4.2   2019-06-29 [1] CRAN (R 3.5.3)
#>  pkgbuild      1.0.3   2019-03-20 [1] CRAN (R 3.5.3)
#>  pkgconfig     2.0.3   2019-09-22 [1] CRAN (R 3.5.3)
#>  pkgload       1.0.2   2018-10-29 [1] CRAN (R 3.5.3)
#>  prettyunits   1.0.2   2015-07-13 [1] CRAN (R 3.5.3)
#>  processx      3.4.1   2019-07-18 [1] CRAN (R 3.5.3)
#>  ps            1.3.0   2018-12-21 [1] CRAN (R 3.5.3)
#>  R6            2.4.1   2019-11-12 [1] CRAN (R 3.5.3)
#>  Rcpp          1.0.3   2019-11-08 [1] CRAN (R 3.5.3)
#>  remotes       2.0.4   2019-04-10 [1] CRAN (R 3.5.3)
#>  rlang         0.4.2   2019-11-23 [1] CRAN (R 3.5.3)
#>  rmarkdown     2.1     2020-01-20 [1] CRAN (R 3.6.2)
#>  rprojroot     1.3-2   2018-01-03 [1] CRAN (R 3.5.3)
#>  sessioninfo   1.1.1   2018-11-05 [1] CRAN (R 3.5.3)
#>  storr         1.2.1   2018-10-18 [1] CRAN (R 3.5.3)
#>  stringi       1.4.3   2019-03-12 [1] CRAN (R 3.5.3)
#>  stringr       1.4.0   2019-02-10 [1] CRAN (R 3.5.3)
#>  testthat      2.2.1   2019-07-25 [1] CRAN (R 3.5.3)
#>  tibble        2.1.3   2019-06-06 [1] CRAN (R 3.5.3)
#>  txtq          0.2.0   2019-10-15 [1] CRAN (R 3.5.3)
#>  usethis       1.5.0   2019-04-07 [1] CRAN (R 3.5.3)
#>  utf8          1.1.4   2018-05-24 [1] CRAN (R 3.5.3)
#>  vctrs         0.2.0   2019-07-05 [1] CRAN (R 3.5.3)
#>  withr         2.1.2   2018-03-15 [1] CRAN (R 3.5.3)
#>  xfun          0.11    2019-11-12 [1] CRAN (R 3.5.3)
#>  yaml          2.2.0   2018-07-25 [1] CRAN (R 3.5.3)
#>  zeallot       0.1.0   2018-01-28 [1] CRAN (R 3.5.3)
#> 
#> [1] C:/Program Files/R/library

Expected result

Ideally, it should not matter how the symbols used in .id look like.
@matthiasgomolka
Copy link
Contributor Author

My apologies for the not ideal formatting. At work, I only have Edge which is not fully supported by GitHub.

@wlandau
Copy link
Member

wlandau commented Jan 24, 2020 •
edited
Loading

I cannot reproduce what you see on Mac or Linux (R 3.6.0). Seems odd that Windows or the version of R would make a difference.

library(drake)

n <- seq_len(2)
ids <- rlang::syms(as.character(n))

plan <- drake_plan(
  numeric_ids = target(
    rnorm(n),
    transform = map(
      n = !!n,
      ids = !!ids,
      .id = ids
    )
  )
)

make(plan)
#> target numeric_ids_.2.
#> target numeric_ids_.1.

make(plan)
#> All targets are already up to date.

Created on 2020-01-24 by the reprex package (v0.3.0)

Session info 
devtools::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#>  setting  value                       
#>  version  R version 3.6.1 (2019-07-05)
#>  os       macOS Mojave 10.14.6        
#>  system   x86_64, darwin15.6.0        
#>  ui       X11                         
#>  language (EN)                        
#>  collate  en_US.UTF-8                 
#>  ctype    en_US.UTF-8                 
#>  tz       America/Indiana/Indianapolis
#>  date     2020-01-24                  
#> 
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package     * version    date       lib source                              
#>  assertthat    0.2.1      2019-03-21 [1] CRAN (R 3.6.0)                      
#>  backports     1.1.5      2019-10-02 [1] CRAN (R 3.6.1)                      
#>  base64url     1.4        2019-05-19 [1] Github (mllg/base64url@d76b9b4)     
#>  callr         3.4.0      2019-12-09 [1] CRAN (R 3.6.0)                      
#>  cli           2.0.1      2020-01-08 [1] CRAN (R 3.6.0)                      
#>  crayon        1.3.4      2017-09-16 [1] CRAN (R 3.6.0)                      
#>  desc          1.2.0      2019-08-19 [1] Github (r-lib/desc@c860e7b)         
#>  devtools      2.2.1      2019-09-24 [1] CRAN (R 3.6.0)                      
#>  digest        0.6.23.2   2020-01-03 [1] Github (eddelbuettel/digest@199be2e)
#>  drake       * 7.9.0      2020-01-08 [1] CRAN (R 3.6.0)                      
#>  ellipsis      0.3.0      2019-09-20 [1] CRAN (R 3.6.0)                      
#>  evaluate      0.14       2019-05-28 [1] CRAN (R 3.6.0)                      
#>  fansi         0.4.1      2020-01-08 [1] CRAN (R 3.6.0)                      
#>  filelock      1.0.2      2018-10-05 [1] CRAN (R 3.6.0)                      
#>  fs            1.3.1      2019-05-06 [1] CRAN (R 3.6.0)                      
#>  glue          1.3.1      2019-03-12 [1] CRAN (R 3.6.0)                      
#>  highr         0.8        2019-03-20 [1] CRAN (R 3.6.0)                      
#>  htmltools     0.4.0      2019-10-04 [1] CRAN (R 3.6.0)                      
#>  igraph        1.2.4.2    2019-11-27 [1] CRAN (R 3.6.0)                      
#>  knitr         1.27       2020-01-16 [1] CRAN (R 3.6.0)                      
#>  magrittr      1.5        2014-11-22 [1] CRAN (R 3.6.0)                      
#>  memoise       1.1.0      2017-04-21 [1] CRAN (R 3.6.0)                      
#>  pillar        1.4.3      2019-12-20 [1] CRAN (R 3.6.0)                      
#>  pkgbuild      1.0.6      2019-10-09 [1] CRAN (R 3.6.0)                      
#>  pkgconfig     2.0.3      2019-09-22 [1] CRAN (R 3.6.1)                      
#>  pkgload       1.0.2      2018-10-29 [1] CRAN (R 3.6.0)                      
#>  prettyunits   1.1.0      2020-01-09 [1] CRAN (R 3.6.1)                      
#>  processx      3.4.1      2019-07-18 [1] CRAN (R 3.6.0)                      
#>  ps            1.3.0      2018-12-21 [1] CRAN (R 3.6.0)                      
#>  R6            2.4.1      2019-11-12 [1] CRAN (R 3.6.1)                      
#>  Rcpp          1.0.3      2019-11-08 [1] CRAN (R 3.6.0)                      
#>  remotes       2.1.0      2019-06-24 [1] CRAN (R 3.6.0)                      
#>  rlang         0.4.2      2019-11-23 [1] CRAN (R 3.6.0)                      
#>  rmarkdown     2.1        2020-01-20 [1] CRAN (R 3.6.1)                      
#>  rprojroot     1.3-2      2018-01-03 [1] CRAN (R 3.6.0)                      
#>  sessioninfo   1.1.1      2018-11-05 [1] CRAN (R 3.6.0)                      
#>  storr         1.2.1      2018-10-18 [1] CRAN (R 3.6.0)                      
#>  stringi       1.4.5      2020-01-11 [1] CRAN (R 3.6.0)                      
#>  stringr       1.4.0      2019-02-10 [1] CRAN (R 3.6.0)                      
#>  testthat      2.3.1      2019-12-01 [1] CRAN (R 3.6.0)                      
#>  tibble        2.1.3      2019-06-06 [1] CRAN (R 3.6.0)                      
#>  txtq          0.2.0.9000 2019-12-05 [1] local                               
#>  usethis       1.5.1.9000 2019-08-12 [1] Github (r-lib/usethis@b241420)      
#>  vctrs         0.2.1      2019-12-17 [1] CRAN (R 3.6.1)                      
#>  withr         2.1.2      2018-03-15 [1] CRAN (R 3.6.0)                      
#>  xfun          0.12       2020-01-13 [1] CRAN (R 3.6.0)                      
#>  yaml          2.2.0      2018-07-25 [1] CRAN (R 3.6.0)                      
#>  zeallot       0.1.0      2018-01-28 [1] CRAN (R 3.6.0)                      
#> 
#> [1] /Library/Frameworks/R.framework/Versions/3.6/Resources/library

@wlandau
Copy link
Member

wlandau commented Jan 24, 2020

This probably got lost in the comment above: would you investigate with cached() and deps_profile()?

library(drake)

n <- seq_len(2)
ids <- rlang::syms(as.character(n))

plan <- drake_plan(
  numeric_ids = target(
    rnorm(n),
    transform = map(
      n = !!n,
      ids = !!ids,
      .id = ids
    )
  )
)

make(plan)
#> target numeric_ids_.2.
#> target numeric_ids_.1.

make(plan)
#> All targets are already up to date.

config <- drake_config(plan)

cached() # numeric_ids_.1. should be there.
#> [1] "numeric_ids_.1." "numeric_ids_.2."

# The `changed` column should be all FALSE.
deps_profile(numeric_ids_.1., config)
#> # A tibble: 5 x 4
#>   name     changed old                new               
#>   <chr>    <lgl>   <chr>              <chr>             
#> 1 command  FALSE   "5a074681f8dfbea9" "5a074681f8dfbea9"
#> 2 depend   FALSE   ""                 ""                
#> 3 file_in  FALSE   ""                 ""                
#> 4 file_out FALSE   ""                 ""                
#> 5 seed     FALSE   "39546070"         "39546070"

Created on 2020-01-24 by the reprex package (v0.3.0)

Session info 
devtools::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#>  setting  value                       
#>  version  R version 3.6.1 (2019-07-05)
#>  os       macOS Mojave 10.14.6        
#>  system   x86_64, darwin15.6.0        
#>  ui       X11                         
#>  language (EN)                        
#>  collate  en_US.UTF-8                 
#>  ctype    en_US.UTF-8                 
#>  tz       America/Indiana/Indianapolis
#>  date     2020-01-24                  
#> 
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package     * version    date       lib source                              
#>  assertthat    0.2.1      2019-03-21 [1] CRAN (R 3.6.0)                      
#>  backports     1.1.5      2019-10-02 [1] CRAN (R 3.6.1)                      
#>  base64url     1.4        2019-05-19 [1] Github (mllg/base64url@d76b9b4)     
#>  callr         3.4.0      2019-12-09 [1] CRAN (R 3.6.0)                      
#>  cli           2.0.1      2020-01-08 [1] CRAN (R 3.6.0)                      
#>  crayon        1.3.4      2017-09-16 [1] CRAN (R 3.6.0)                      
#>  desc          1.2.0      2019-08-19 [1] Github (r-lib/desc@c860e7b)         
#>  devtools      2.2.1      2019-09-24 [1] CRAN (R 3.6.0)                      
#>  digest        0.6.23.2   2020-01-03 [1] Github (eddelbuettel/digest@199be2e)
#>  drake       * 7.9.0      2020-01-08 [1] CRAN (R 3.6.0)                      
#>  ellipsis      0.3.0      2019-09-20 [1] CRAN (R 3.6.0)                      
#>  evaluate      0.14       2019-05-28 [1] CRAN (R 3.6.0)                      
#>  fansi         0.4.1      2020-01-08 [1] CRAN (R 3.6.0)                      
#>  filelock      1.0.2      2018-10-05 [1] CRAN (R 3.6.0)                      
#>  fs            1.3.1      2019-05-06 [1] CRAN (R 3.6.0)                      
#>  glue          1.3.1      2019-03-12 [1] CRAN (R 3.6.0)                      
#>  highr         0.8        2019-03-20 [1] CRAN (R 3.6.0)                      
#>  htmltools     0.4.0      2019-10-04 [1] CRAN (R 3.6.0)                      
#>  igraph        1.2.4.2    2019-11-27 [1] CRAN (R 3.6.0)                      
#>  knitr         1.27       2020-01-16 [1] CRAN (R 3.6.0)                      
#>  magrittr      1.5        2014-11-22 [1] CRAN (R 3.6.0)                      
#>  memoise       1.1.0      2017-04-21 [1] CRAN (R 3.6.0)                      
#>  pillar        1.4.3      2019-12-20 [1] CRAN (R 3.6.0)                      
#>  pkgbuild      1.0.6      2019-10-09 [1] CRAN (R 3.6.0)                      
#>  pkgconfig     2.0.3      2019-09-22 [1] CRAN (R 3.6.1)                      
#>  pkgload       1.0.2      2018-10-29 [1] CRAN (R 3.6.0)                      
#>  prettyunits   1.1.0      2020-01-09 [1] CRAN (R 3.6.1)                      
#>  processx      3.4.1      2019-07-18 [1] CRAN (R 3.6.0)                      
#>  ps            1.3.0      2018-12-21 [1] CRAN (R 3.6.0)                      
#>  R6            2.4.1      2019-11-12 [1] CRAN (R 3.6.1)                      
#>  Rcpp          1.0.3      2019-11-08 [1] CRAN (R 3.6.0)                      
#>  remotes       2.1.0      2019-06-24 [1] CRAN (R 3.6.0)                      
#>  rlang         0.4.2      2019-11-23 [1] CRAN (R 3.6.0)                      
#>  rmarkdown     2.1        2020-01-20 [1] CRAN (R 3.6.1)                      
#>  rprojroot     1.3-2      2018-01-03 [1] CRAN (R 3.6.0)                      
#>  sessioninfo   1.1.1      2018-11-05 [1] CRAN (R 3.6.0)                      
#>  storr         1.2.1      2018-10-18 [1] CRAN (R 3.6.0)                      
#>  stringi       1.4.5      2020-01-11 [1] CRAN (R 3.6.0)                      
#>  stringr       1.4.0      2019-02-10 [1] CRAN (R 3.6.0)                      
#>  testthat      2.3.1      2019-12-01 [1] CRAN (R 3.6.0)                      
#>  tibble        2.1.3      2019-06-06 [1] CRAN (R 3.6.0)                      
#>  txtq          0.2.0.9000 2019-12-05 [1] local                               
#>  usethis       1.5.1.9000 2019-08-12 [1] Github (r-lib/usethis@b241420)      
#>  utf8          1.1.4      2018-05-24 [1] CRAN (R 3.6.0)                      
#>  vctrs         0.2.1      2019-12-17 [1] CRAN (R 3.6.1)                      
#>  withr         2.1.2      2018-03-15 [1] CRAN (R 3.6.0)                      
#>  xfun          0.12       2020-01-13 [1] CRAN (R 3.6.0)                      
#>  yaml          2.2.0      2018-07-25 [1] CRAN (R 3.6.0)                      
#>  zeallot       0.1.0      2018-01-28 [1] CRAN (R 3.6.0)                      
#> 
#> [1] /Library/Frameworks/R.framework/Versions/3.6/Resources/library

@wlandau
Copy link
Member

wlandau commented Jan 25, 2020

Reproduced on Windows. Strange that this is an OS-specific issue.

library(drake)

packageVersion("drake")
#> [1] '7.9.0.9000'

n <- seq_len(2)
ids <- rlang::syms(as.character(n))

plan <- drake_plan(
  numeric_ids = target(
    rnorm(n),
    transform = map(
      n = !!n,
      ids = !!ids,
      .id = ids
    )
  )
)

make(plan)
#> target numeric_ids_.2.
#> target numeric_ids_.1.

make(plan)
#> target numeric_ids_.2.
#> target numeric_ids_.1.

Created on 2020-01-25 by the reprex package (v0.3.0)

Session info 
devtools::session_info()
#> - Session info ---------------------------------------------------------------
#>  setting  value                       
#>  version  R version 3.6.1 (2019-07-05)
#>  os       Windows 10 x64              
#>  system   x86_64, mingw32             
#>  ui       RTerm                       
#>  language (EN)                        
#>  collate  English_United States.1252  
#>  ctype    English_United States.1252  
#>  tz       America/New_York            
#>  date     2020-01-25                  
#> 
#> - Packages -------------------------------------------------------------------
#>  package     * version    date       lib source                              
#>  assertthat    0.2.1      2019-03-21 [1] CRAN (R 3.6.1)                      
#>  backports     1.1.5      2019-10-02 [1] CRAN (R 3.6.1)                      
#>  base64url     1.4        2018-05-14 [1] CRAN (R 3.6.1)                      
#>  callr         3.4.1      2020-01-24 [1] CRAN (R 3.6.1)                      
#>  cli           2.0.1      2020-01-08 [1] CRAN (R 3.6.2)                      
#>  crayon        1.3.4      2017-09-16 [1] CRAN (R 3.6.1)                      
#>  desc          1.2.0      2018-05-01 [1] CRAN (R 3.6.1)                      
#>  devtools      2.2.1      2019-09-24 [1] CRAN (R 3.6.1)                      
#>  digest        0.6.23     2019-12-08 [1] Github (eddelbuettel/digest@c08d77f)
#>  drake       * 7.9.0.9000 2020-01-25 [1] local                               
#>  ellipsis      0.3.0      2019-09-20 [1] CRAN (R 3.6.1)                      
#>  evaluate      0.14       2019-05-28 [1] CRAN (R 3.6.1)                      
#>  fansi         0.4.1      2020-01-08 [1] CRAN (R 3.6.2)                      
#>  filelock      1.0.2      2018-10-05 [1] CRAN (R 3.6.1)                      
#>  fs            1.3.1      2019-05-06 [1] CRAN (R 3.6.1)                      
#>  glue          1.3.1      2019-03-12 [1] CRAN (R 3.6.1)                      
#>  highr         0.8        2019-03-20 [1] CRAN (R 3.6.1)                      
#>  htmltools     0.4.0      2019-10-04 [1] CRAN (R 3.6.1)                      
#>  igraph        1.2.4.2    2019-11-27 [1] CRAN (R 3.6.1)                      
#>  knitr         1.27       2020-01-16 [1] CRAN (R 3.6.2)                      
#>  magrittr      1.5        2014-11-22 [1] CRAN (R 3.6.1)                      
#>  memoise       1.1.0      2017-04-21 [1] CRAN (R 3.6.1)                      
#>  pillar        1.4.3      2019-12-20 [1] CRAN (R 3.6.2)                      
#>  pkgbuild      1.0.6      2019-10-09 [1] CRAN (R 3.6.1)                      
#>  pkgconfig     2.0.3      2019-09-22 [1] CRAN (R 3.6.1)                      
#>  pkgload       1.0.2      2018-10-29 [1] CRAN (R 3.6.1)                      
#>  prettyunits   1.1.1      2020-01-24 [1] CRAN (R 3.6.1)                      
#>  processx      3.4.1      2019-07-18 [1] CRAN (R 3.6.1)                      
#>  ps            1.3.0      2018-12-21 [1] CRAN (R 3.6.1)                      
#>  R6            2.4.1      2019-11-12 [1] CRAN (R 3.6.1)                      
#>  Rcpp          1.0.3      2019-11-08 [1] CRAN (R 3.6.1)                      
#>  remotes       2.1.0      2019-06-24 [1] CRAN (R 3.6.1)                      
#>  rlang         0.4.3      2020-01-24 [1] CRAN (R 3.6.1)                      
#>  rmarkdown     2.1        2020-01-20 [1] CRAN (R 3.6.2)                      
#>  rprojroot     1.3-2      2018-01-03 [1] CRAN (R 3.6.1)                      
#>  sessioninfo   1.1.1      2018-11-05 [1] CRAN (R 3.6.1)                      
#>  storr         1.2.2      2019-12-03 [1] local                               
#>  stringi       1.4.5      2020-01-11 [1] CRAN (R 3.6.1)                      
#>  stringr       1.4.0      2019-02-10 [1] CRAN (R 3.6.1)                      
#>  testthat      2.3.1      2019-12-01 [1] CRAN (R 3.6.1)                      
#>  tibble        2.1.3      2019-06-06 [1] CRAN (R 3.6.1)                      
#>  txtq          0.2.0      2019-10-15 [1] CRAN (R 3.6.1)                      
#>  usethis       1.5.1      2019-07-04 [1] CRAN (R 3.6.1)                      
#>  vctrs         0.2.2      2020-01-24 [1] CRAN (R 3.6.1)                      
#>  withr         2.1.2      2018-03-15 [1] CRAN (R 3.6.1)                      
#>  xfun          0.12       2020-01-13 [1] CRAN (R 3.6.2)                      
#>  yaml          2.2.0      2018-07-25 [1] CRAN (R 3.6.0)                      
#> 
#> [1] C:/R/R-3.6.1/library

@wlandau
Copy link
Member

wlandau commented Jan 25, 2020

Fixed.

wlandau pushed a commit that referenced this issue Jan 25, 2020
@wlandau-lilly
Fix test errors in #1147
7544e8a
@matthiasgomolka
Copy link
Contributor Author

This was quick, thanks!

wlandau-lilly added a commit that referenced this issue Feb 14, 2020
@wlandau-lilly
Warn when converting trailing dots (#1147)
0462a5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wlandau wlandau

Labels
type: edge case
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wlandau @matthiasgomolka