Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove the session argument of make() #623

Closed
wlandau opened this issue Dec 17, 2018 · 2 comments
Closed

Deprecate and remove the session argument of make() #623

wlandau opened this issue Dec 17, 2018 · 2 comments

Comments

@wlandau
Copy link
Member

wlandau commented Dec 17, 2018

@rkrug originally raised #330 (comment) as a potential problem. By default, drake is sensitive to the environment in which make() is called. But I think we no longer need the session argument of make(). Reasons:

@wlandau
Copy link
Member Author

wlandau commented Dec 17, 2018

Also cc @krlmlr, @AlexAxthelm

@wlandau
Copy link
Member Author

wlandau commented Dec 17, 2018

If you do not want to use the global environment, I recommend source()ing your scripts into a custom environment (new.env(parent = globalenv()) and then supplying it to the envir argument of make(). I should probably provide guidance on this in the manual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant