Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulation of hash tables #1011

Merged
merged 6 commits into from
Sep 13, 2019
Merged

Encapsulation of hash tables #1011

merged 6 commits into from
Sep 13, 2019

Conversation

wlandau
Copy link
Member

@wlandau wlandau commented Sep 13, 2019

Summary

Previously, the decorated storr had public hash tables and expected external functions to use them. Now, those hash tables can be accessed entirely with easier-to-use methods in the decorated storr itself. Encapsulation +1.

Related GitHub issues and pull requests

Checklist

@wlandau wlandau self-assigned this Sep 13, 2019
@codecov-io
Copy link

codecov-io commented Sep 13, 2019

Codecov Report

Merging #1011 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1011   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          47      46    -1     
  Lines        6419    6422    +3     
======================================
+ Hits         6419    6422    +3
Impacted Files Coverage Δ
R/drake_config.R 100% <ø> (ø) ⬆️
R/clean.R 100% <100%> (ø) ⬆️
R/analyze_code.R 100% <100%> (ø) ⬆️
R/text_drake_graph.R 100% <100%> (ø) ⬆️
R/deprecated.R 100% <100%> (ø) ⬆️
R/cache.R 100% <100%> (ø) ⬆️
R/deps.R 100% <100%> (ø) ⬆️
R/decorate_storr.R 100% <100%> (ø) ⬆️
R/local_build.R 100% <100%> (ø) ⬆️
R/make.R 100% <100%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47169aa...8112b2f. Read the comment docs.

@wlandau wlandau merged commit 9700619 into master Sep 13, 2019
@wlandau wlandau deleted the 968 branch September 13, 2019 15:49
@wlandau wlandau mentioned this pull request Sep 13, 2019
2 tasks
@wlandau wlandau changed the title Encapsulation the hash tables Encapsulation of hash tables Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants