Pre-work leading up to difficult parallelism issues #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 61 63 +2
Lines 4352 4360 +8
=====================================
+ Hits 4352 4360 +8
Continue to review full report at Codecov.
|
|
The longer, more thorough checks look good too. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fine-tunes the building and caching infrastructure, and it should make #227, #233, #237, and #239 much easier to solve. I also think it solves #236 to the full extent possible before direct implementation begins for #237. Details:
build_target()so that it does not need access to the cache. Add a unit test to track.drake_build()andstore_target(). The logic is clearer, more readable, and more modular. It will help us to write a version ofdrake_build()that lets the master process do the caching (Manual scheduling #227, Addfuturesupport for the Makefile backend. #237).staged_parallelism.R. Similarly put other functions in the files where they belong.This PR polishes some super sensitive internals, so regular unit testing is not good enough. I will do the pre-CRAN long-running tests on all backends and then test on an old work project before I merge this tomorrow.