From 0d8e1053a44c6d80b889273f240a20121df17d2f Mon Sep 17 00:00:00 2001 From: Eric Leung Date: Sat, 26 Oct 2019 10:11:04 -0700 Subject: [PATCH 1/2] Fix typo in formatting inline code in README --- README.Rmd | 2 +- README.md | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/README.Rmd b/README.Rmd index d66a8b15..fae40331 100644 --- a/README.Rmd +++ b/README.Rmd @@ -220,7 +220,7 @@ RMarkdown documents, it cannot in other circumstances. This includes: One workaround for showing these characters in Windows is to set the CTYPE part of your locale to Chinese/Japanese/Korean with `Sys.setlocale("LC_CTYPE", -"Chinese"). The helper function `fix_windows_histograms()` does this for you. +"Chinese")`. The helper function `fix_windows_histograms()` does this for you. And last but not least, we provide `skim_without_charts()` as a fallback. This makes it easy to still get summaries of your data, even if unicode issues diff --git a/README.md b/README.md index b76f2eff..ab3f9f57 100644 --- a/README.md +++ b/README.md @@ -641,10 +641,9 @@ includes: - in the context of rendering to a pdf using an engine that does not support utf-8. -One workaround for showing these characters in Windows is to set the -CTYPE part of your locale to Chinese/Japanese/Korean with -`Sys.setlocale("LC_CTYPE", "Chinese"). The helper function`fix\_windows\_histograms()\` -does this for you. +One workaround for showing these characters in Windows is to set the CTYPE part +of your locale to Chinese/Japanese/Korean with `Sys.setlocale("LC_CTYPE", +"Chinese")`. The helper function `fix_windows_histograms()` does this for you. And last but not least, we provide `skim_without_charts()` as a fallback. This makes it easy to still get summaries of your data, even From 1613121162155baad54af63823790f57f112100a Mon Sep 17 00:00:00 2001 From: Elin Waring Date: Sat, 26 Oct 2019 23:58:27 -0400 Subject: [PATCH 2/2] Add condition for when no defaults at all are defined (e.g. during build). --- R/skim_with.R | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/R/skim_with.R b/R/skim_with.R index 25247ff2..47b6985d 100644 --- a/R/skim_with.R +++ b/R/skim_with.R @@ -145,7 +145,8 @@ validate_assignment <- function(...) { defaults <- get_default_skimmers() existing <- proposed_names %in% names(defaults) - if (!all(existing)) { + + if (!all(existing) & length(defaults) > 0 ) { collapsed <- paste(proposed_names[!existing], collapse = ", ") message( "Creating new skimming functions for the following classes: ",