Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ots_inflation_adjustment() drops reference year #38

Closed
michalovadek opened this issue Apr 10, 2021 · 3 comments
Closed

ots_inflation_adjustment() drops reference year #38

michalovadek opened this issue Apr 10, 2021 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@michalovadek
Copy link

Hi, thanks for this super useful package. I noticed running ots_inflation_adjustment() shrank the original dataset and then realized this was due to the reference year being dropped. If this is desired behaviour, it would be good to add it to the function documentation. I would argue though that if the data for the reference year are found in the original data.frame, it should simply be left there unchanged.

@pachadotdev
Copy link
Collaborator

hi Michael
so sorry for the delay (writing thesis here, but still inexcusable)
please @ me when you have questions
and yes, for my uses I drop the reference year since the factor for it is 1
I'll change that for the next version

@pachadotdev pachadotdev added the good first issue Good for newcomers label Jul 6, 2021
@pachadotdev pachadotdev self-assigned this Jul 6, 2021
@pachadotdev
Copy link
Collaborator

hi @michalovadek
sorry for the delays, i just repaired my laptop, and now i'm updating the API and the functions to keep the reference year

@pachadotdev
Copy link
Collaborator

@michalovadek Hi!! I have updated the function, but more important than it: I've tested the update and it works properly
I've also changes the input data for the discount rate, and now I'm using the weighted median, as I noticed that some years with hiper-inflation in some countries really distorted the mean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants