Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serializer methods re-work? #189

Closed
sckott opened this issue Nov 15, 2020 · 0 comments
Closed

Serializer methods re-work? #189

sckott opened this issue Nov 15, 2020 · 0 comments
Milestone
v0.6

Comments

@sckott
Copy link
Collaborator

sckott commented Nov 15, 2020

Seems that deserialize_string method in the JSON/YAML classes isn't used at all. If so, remove it and rename deserialize_path, which is used, to just deserialize (which will nicely match serialize - and match Ruby vcr)
@sckott sckott added this to the v0.6 milestone Nov 15, 2020
@sckott sckott closed this as completed in 521a124 Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6
Development

No branches or pull requests
1 participant
@sckott