Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually use up_to_date_interactions method in Cassette #96

Closed
sckott opened this issue Feb 11, 2019 · 1 comment
Closed

Actually use up_to_date_interactions method in Cassette #96

sckott opened this issue Feb 11, 2019 · 1 comment
Milestone
v0.3

Comments

@sckott
Copy link
Collaborator

sckott commented Feb 11, 2019

Should be used in merged_interactions method within Cassette - is not used at all right now.

In ruby they run old_interactions through up_to_date_interactions before exiting https://github.com/sckott/vcr/blob/master/lib/vcr/cassette.rb#L258

up_to_date_interactions(old_interactions) + new_recorded_interactions
@sckott sckott added this to the v0.3 milestone Feb 11, 2019
@sckott sckott mentioned this issue Feb 11, 2019
Open
@sckott
Copy link
Collaborator Author

sckott commented Jul 24, 2019

fixed via #104

@sckott sckott closed this as completed Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3
Development

No branches or pull requests
1 participant
@sckott