Added qos autodetect #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
jacobperron
reviewed
Jul 15, 2021
src/rqt_plot/rosplot.py
Outdated
Comment on lines
104
to
106
| data_class = get_message(topic_type) | ||
| data_class = get_message_class(topic_type) |
There was a problem hiding this comment.
What's the reason for this change? IMO, it seems like a backwards step. I would prefer to use the utility further upstream, all else being equal.
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
jacobperron
reviewed
Aug 10, 2021
src/rqt_plot/rosplot.py
Outdated
Comment on lines
42
to
44
| from rosidl_runtime_py.utilities import get_message | ||
| from rclpy.qos import QoSReliabilityPolicy | ||
| from rqt_py_common.message_helpers import get_message_class |
There was a problem hiding this comment.
We need to also undo the change to the imports. We're using get_message from rosidl_runtime_py instead of get_message_class.
Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
jacobperron
approved these changes
Aug 11, 2021
|
CI build:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gonzalo de Pedro gonzalo@depedro.com.ar