Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes the use of __slots__ for the field and field type getter #87

Merged

Conversation

Voldivh
Copy link
Contributor

@Voldivh Voldivh commented Apr 3, 2023

This PR modifies the use of slots for the appropriate message components name getter. This changes should solve the problems when ros2/rosidl_python#194 is incorporated.

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
@Voldivh Voldivh requested a review from methylDragon as a code owner April 3, 2023 19:48
@clalancette
Copy link
Contributor

clalancette commented Apr 3, 2023

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
src/rqt_plot/plot_widget.py Outdated Show resolved Hide resolved
Voldivh added 2 commits April 3, 2023 17:46
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 7693fbb into ros-visualization:rolling Apr 4, 2023
@Voldivh Voldivh deleted the voldivh/use_of_field_getter branch April 4, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants