Drop Mesa workaround #1714
Drop Mesa workaround #1714
Conversation
|
|
||
| std::string gl_version_string = (const char*)glGetString(GL_VERSION); | ||
| // The "Mesa 2" string is intended to match "Mesa 20.", "Mesa 21." and so on | ||
| mesa_workaround = gl_version_string.find("Mesa 2") != std::string::npos && gl_version_ >= 320; |
There was a problem hiding this comment.
My suggestion would have been to just change this to "Mesa 20"
There was a problem hiding this comment.
Was the Mesa 20 part of some HWE or part of the stock 18.04, ie are there likely going to be people with non HWE systems running into this again?
There was a problem hiding this comment.
$ LANG=C apt-cache policy mesa-va-drivers
mesa-va-drivers:
Installed: 21.3.6~kisak1~b
Candidate: 21.3.6~kisak1~b
Version table:
*** 21.3.6~kisak1~b 500
500 http://ppa.launchpad.net/kisak/kisak-mesa/ubuntu bionic/main amd64 Packages
100 /var/lib/dpkg/status
20.0.8-0ubuntu1~18.04.1 500
500 http://cz.archive.ubuntu.com/ubuntu bionic-updates/universe amd64 Packages
19.2.8-0ubuntu0~18.04.2 500
500 http://security.ubuntu.com/ubuntu bionic-security/universe amd64 Packages
18.0.0~rc5-1ubuntu1 500
500 http://cz.archive.ubuntu.com/ubuntu bionic/universe amd64 Packages
There was a problem hiding this comment.
That's on Bionic HWE with kisak-mesa PPA. So it seems 20.x is available via bionic-updates for everyone.
|
I was just testing around with the PC2 display on AMD Renoir and noticed that most of the more fancy Styles seem to be unsupported with GLSL 1.5. Changing the Size has no effect for anything besides Points and it's always displayed as super tiny dots. I was not able to trigger any unusual behavior with the Points style We have serious performance regressions with high resolution octomaps when limiting to the older shader versions though, that's why I opened the discussion. |
|
Interesting, I also tested that on Renoir and it did not work for me with Mesa 21, that's why I requested the workaround to be extended to all 2x versions. |
|
Your test was with Mesa 21.0.0 while the fix appeared in 21.0.3 (I'm not sure it has been pinpointed exactly but maybe I misunderstood something ...) |
|
@simonschmeisser Good point, haven't noticed that... Could you put together a minimum working example? It's been some time since I was solving this, so I can't remember what were the steps to receive a failure... |
|
I'm not sure I fully understood your comments. Thus, let me try to summarize. @peci1 and @simonschmeisser, please correct!
|
Bionic has only Mesa 20. So this fix hasn't been released there. I (and probably others) are using a customized Mesa PPA to get a newer Mesa on Bionic, as that's the only way to get the new Ryzen GPUs working (together with mainline kernels). |
|
I tested on Bionic+Ryzen GPU+Mesa 21 with and without the Mesa workaround: With workaround: everything works (I haven't tested performance, though). Without workaround: Points are displayed with correct size, but there is this (new?) issue with everything except points displaying as a single white dot: I've opened an issue for the "newly discovered" bug (#1721), but I think this PR needs to be hold off until that issue is solved. |
You are right. I was writing my comment in a rush obviously... |
|
@peci1, note that you can manually enforce an older OpenGL standard: |
Yes, but this combines very badly with already existing launch files starting rviz. Maybe if it were an environment variable, it would be easier to set globally. |
|
What about |
|
|
|
Closing for now, as our GLSL 1.50 scripts are not Mesa-compatible yet. |
Addressing #1701. Needs to be tested on various systems!