From 115ffb5bfb9974a5013a1e94899e96bb7c0bd3a0 Mon Sep 17 00:00:00 2001 From: James Xu Date: Wed, 30 Jan 2019 14:22:07 -0800 Subject: [PATCH] visibility macros update (#1591) --- clients/roscpp/include/ros/spinner.h | 2 +- clients/roscpp/include/ros/xmlrpc_manager.h | 6 +++--- tools/rosbag_storage/include/rosbag/bag_player.h | 2 +- tools/rosbag_storage/include/rosbag/view.h | 2 +- utilities/xmlrpcpp/include/xmlrpcpp/XmlRpcUtil.h | 6 +++--- utilities/xmlrpcpp/include/xmlrpcpp/XmlRpcValue.h | 2 +- utilities/xmlrpcpp/libb64/include/b64/decode.h | 4 +++- utilities/xmlrpcpp/libb64/include/b64/encode.h | 4 +++- 8 files changed, 16 insertions(+), 12 deletions(-) diff --git a/clients/roscpp/include/ros/spinner.h b/clients/roscpp/include/ros/spinner.h index d09f0a090e..b862e1b31a 100644 --- a/clients/roscpp/include/ros/spinner.h +++ b/clients/roscpp/include/ros/spinner.h @@ -55,7 +55,7 @@ class ROSCPP_DECL Spinner /** * \brief Spinner which runs in a single thread. */ -class SingleThreadedSpinner : public Spinner +class ROSCPP_DECL SingleThreadedSpinner : public Spinner { public: virtual void spin(CallbackQueue* queue = 0); diff --git a/clients/roscpp/include/ros/xmlrpc_manager.h b/clients/roscpp/include/ros/xmlrpc_manager.h index b621e93dbb..0d41f12cf1 100644 --- a/clients/roscpp/include/ros/xmlrpc_manager.h +++ b/clients/roscpp/include/ros/xmlrpc_manager.h @@ -49,9 +49,9 @@ namespace ros */ namespace xmlrpc { -XmlRpc::XmlRpcValue responseStr(int code, const std::string& msg, const std::string& response); -XmlRpc::XmlRpcValue responseInt(int code, const std::string& msg, int response); -XmlRpc::XmlRpcValue responseBool(int code, const std::string& msg, bool response); +ROSCPP_DECL XmlRpc::XmlRpcValue responseStr(int code, const std::string& msg, const std::string& response); +ROSCPP_DECL XmlRpc::XmlRpcValue responseInt(int code, const std::string& msg, int response); +ROSCPP_DECL XmlRpc::XmlRpcValue responseBool(int code, const std::string& msg, bool response); } class XMLRPCCallWrapper; diff --git a/tools/rosbag_storage/include/rosbag/bag_player.h b/tools/rosbag_storage/include/rosbag/bag_player.h index a94eb017ea..c3e70f11bc 100644 --- a/tools/rosbag_storage/include/rosbag/bag_player.h +++ b/tools/rosbag_storage/include/rosbag/bag_player.h @@ -91,7 +91,7 @@ class BagCallbackT : public BagCallback /* A class for playing back bag files at an API level. It supports relatime, as well as accelerated and slowed playback. */ -class BagPlayer +class ROSBAG_STORAGE_DECL BagPlayer { public: /* Constructor expecting the filename of a bag */ diff --git a/tools/rosbag_storage/include/rosbag/view.h b/tools/rosbag_storage/include/rosbag/view.h index 9cdcee98a3..b02f523e80 100644 --- a/tools/rosbag_storage/include/rosbag/view.h +++ b/tools/rosbag_storage/include/rosbag/view.h @@ -57,7 +57,7 @@ class ROSBAG_STORAGE_DECL View * MessageInstance is destroyed. You should never store the * pointer to this reference. */ - class iterator : public boost::iterator_facade { diff --git a/utilities/xmlrpcpp/include/xmlrpcpp/XmlRpcUtil.h b/utilities/xmlrpcpp/include/xmlrpcpp/XmlRpcUtil.h index 0a9232319f..956ddb23cf 100644 --- a/utilities/xmlrpcpp/include/xmlrpcpp/XmlRpcUtil.h +++ b/utilities/xmlrpcpp/include/xmlrpcpp/XmlRpcUtil.h @@ -75,12 +75,12 @@ namespace XmlRpc { }; //! Returns log message verbosity. This is short for XmlRpcLogHandler::getVerbosity() - int getVerbosity(); + XMLRPCPP_DECL int getVerbosity(); //! Sets log message verbosity. This is short for XmlRpcLogHandler::setVerbosity(level) - void setVerbosity(int level); + XMLRPCPP_DECL void setVerbosity(int level); //! Version identifier - extern const char XMLRPC_VERSION[]; + extern XMLRPCPP_DECL const char XMLRPC_VERSION[]; //! Utilities for XML parsing, encoding, and decoding and message handlers. class XMLRPCPP_DECL XmlRpcUtil { diff --git a/utilities/xmlrpcpp/include/xmlrpcpp/XmlRpcValue.h b/utilities/xmlrpcpp/include/xmlrpcpp/XmlRpcValue.h index 50d3c478e8..497f6ba68e 100644 --- a/utilities/xmlrpcpp/include/xmlrpcpp/XmlRpcValue.h +++ b/utilities/xmlrpcpp/include/xmlrpcpp/XmlRpcValue.h @@ -189,7 +189,7 @@ namespace XmlRpc { } // namespace XmlRpc -std::ostream& operator<<(std::ostream& os, const XmlRpc::XmlRpcValue& v); +XMLRPCPP_DECL std::ostream& operator<<(std::ostream& os, const XmlRpc::XmlRpcValue& v); #endif // _XMLRPCVALUE_H_ diff --git a/utilities/xmlrpcpp/libb64/include/b64/decode.h b/utilities/xmlrpcpp/libb64/include/b64/decode.h index 8fd0188faf..9e017f6a4e 100644 --- a/utilities/xmlrpcpp/libb64/include/b64/decode.h +++ b/utilities/xmlrpcpp/libb64/include/b64/decode.h @@ -8,6 +8,8 @@ For details, see http://sourceforge.net/projects/libb64 #ifndef BASE64_DECODE_H #define BASE64_DECODE_H +#include "xmlrpcpp/XmlRpcDecl.h" + #include namespace base64 @@ -17,7 +19,7 @@ namespace base64 #include "cdecode.h" } - struct decoder + struct XMLRPCPP_DECL decoder { base64_decodestate _state; int _buffersize; diff --git a/utilities/xmlrpcpp/libb64/include/b64/encode.h b/utilities/xmlrpcpp/libb64/include/b64/encode.h index dc481b1d9f..98eeb96ad7 100644 --- a/utilities/xmlrpcpp/libb64/include/b64/encode.h +++ b/utilities/xmlrpcpp/libb64/include/b64/encode.h @@ -8,6 +8,8 @@ For details, see http://sourceforge.net/projects/libb64 #ifndef BASE64_ENCODE_H #define BASE64_ENCODE_H +#include "xmlrpcpp/XmlRpcDecl.h" + #include namespace base64 @@ -17,7 +19,7 @@ namespace base64 #include "cencode.h" } - struct encoder + struct XMLRPCPP_DECL encoder { base64_encodestate _state; int _buffersize;