Get Iterable from collections.abc. #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting Iterable from collections was deprecated in Python 3.9 and removed in 3.10. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Using dashes is deprecated. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
sloretz
approved these changes
Jan 27, 2022
| [install] | ||
| install-scripts=$base/share/urdfdom_py/scripts | ||
| install_scripts=$base/share/urdfdom_py/scripts |
There was a problem hiding this comment.
This is different from https://github.com/ros2/examples/blob/master/rclpy/executors/setup.cfg where scripts are installed into $base/lib/package name. I think that's the only place ros2 looks for scripts to run.
There was a problem hiding this comment.
That is an excellent point, and indeed no binaries are found with ros2 run urdfdom_py display_urdf. I'll merge this one in and also open another PR to fix that.
There was a problem hiding this comment.
where can I find this setup.cfg file?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting Iterable from collections was deprecated in Python 3.9 and removed in 3.10.
While I was in here, I noticed that we were getting warnings for a deprecated usage of
script-dirandinstall-scripts, so fix that as well.Fixes #72