Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify that all field must be listed explicitly #109

Merged
merged 1 commit into from
Mar 28, 2018
Merged

clarify that all field must be listed explicitly #109

merged 1 commit into from
Mar 28, 2018

Conversation

dirk-thomas
Copy link
Member

Addressing concern from #108.

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Mar 28, 2018
@dirk-thomas dirk-thomas self-assigned this Mar 28, 2018
@dirk-thomas dirk-thomas mentioned this pull request Mar 28, 2018
Closed
mikaelarguedas
mikaelarguedas approved these changes Mar 28, 2018
View reviewed changes
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dirk-thomas dirk-thomas merged commit f8a6b6d into master Mar 28, 2018
@dirk-thomas dirk-thomas deleted the doc_explicit_field_names branch March 28, 2018 18:56
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirk-thomas @mikaelarguedas