Fix for actions subfolder introduction in ros2 message bridge #143
Conversation
|
Linux packaging: |
|
Looks like the tests are still timing out on the farm. |
|
@sservulo Please build the branch locally and run the tests, e.g. the linters fail which can easily be tested locally. |
|
Yes, there are some |
|
Sorry, I did a small amend and didn't rerun tests before pushing it. Lint errors fixed now. I'm digging the issue in |
ros1_bridge/__init__.py
Outdated
| ros2_msg.prefix_path, 'share', ros2_msg.package_name, message_location, | ||
| ros2_msg.message_name + '.msg') | ||
| if os.path.isfile(message_path): | ||
| break |
There was a problem hiding this comment.
To different type of interfaces with the same name can exist. So only allowing one here seems wrong.
Same below.
There was a problem hiding this comment.
Just to double check, this PR is specifically about stripping subfolders from interface files, not to provide any support for bridging actions, right? If that's the case, then it seems to me we don't need to expose messages generated to implement services nor messages and services generated to implement actions.
|
Linux packaging: |
|
Linux packaging: |
|
For good measure:
|
|
Windows packaging job has warnings. I don't think the warning script is catching this one, not sure how long it's been present. and which might be caused by ros/urdfdom_headers#47/ |
|
I don't think either of those are a blocker, since they are from unrelated packages. |
|
@mjcarroll Is this ready to move forward? |
* Fix for actions subfolder introduction in ros2 message bridge * Updating service_name for action srvs for compatibility * Extended changes on ros1_bridge * Undo of action specific locations to ros1_bridge * lint fixup Signed-off-by: Dhananjay Sathe <dhananjay.sathe@rapyuta-robotics.com>
Relates to the change ros2/rosidl@7d79172 pointed out by @mjcarroll and @dirk-thomas which introduced packaging failures in
ros1_bridge.Deprecates ros2/rosidl#319 .