Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom QoS settings for pub/sub factories #162

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

paulbovbel
Copy link
Contributor

@paulbovbel paulbovbel commented Feb 6, 2019

This allows specifying a custom QoS profile for ROS2 components, or setting a latch flag on the created ROS1 publisher.

@tfoote tfoote added the in review Waiting for review (Kanban column) label Feb 6, 2019
@paulbovbel
Copy link
Contributor Author

anything else I should adjust?

@dirk-thomas
Copy link
Member

Build Status

@dirk-thomas dirk-thomas self-assigned this Feb 7, 2019
@dirk-thomas dirk-thomas merged commit 961ddee into ros2:master Feb 7, 2019
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Feb 7, 2019
dhananjaysathe pushed a commit to rapyuta-robotics/ros1_bridge that referenced this pull request Aug 22, 2019
…#162)

Signed-off-by: Dhananjay Sathe <dhananjay.sathe@rapyuta-robotics.com>
@dirk-thomas
Copy link
Member

@paulbovbel This PR introduced API with an argument type rmw_qos_profile_t. Is there a specific reason for that or could code using this API be updated to use a similar API with an argument type rclcpp::QoS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants