Use interface kind names properly in ROS2 interface type names. #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up after 816b667. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
added
in progress
dirk-thomas
approved these changes
May 15, 2019
|
Alright, going in! |
dhananjaysathe
pushed a commit
to rapyuta-robotics/ros1_bridge
that referenced
this pull request
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up after 816b667, introduced by #191. Prefixes (i.e.
msg,srv) were still missing in a few other places.I managed to reproduce latest test failures on ros2/build_farmer#192 locally and all appear to be fixed by this patch.