Fix building of ros1_bridge against newer roscpp. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment in the code mostly explains it, but because of changes to upstream catkin/roscpp, we need to expand the types of things we look at for linking. With this patch, building against roscpp kinetic 1.12.7 and 1.12.12 works. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org>
|
CI:
|
clalancette
added
in review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment in the code mostly explains it, but because of changes
to upstream catkin/roscpp, we need to expand the types of things
we look at for linking. With this patch, building against
roscpp kinetic 1.12.7 and 1.12.12 works.
fixes ros2/build_farmer#68
Signed-off-by: Chris Lalancette clalancette@osrfoundation.org