Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depend on rosidl_interfaces_packages group #99

Merged
merged 3 commits into from
Nov 30, 2017
Merged

depend on rosidl_interfaces_packages group #99

merged 3 commits into from
Nov 30, 2017

Conversation

mikaelarguedas
Copy link
Member

@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Nov 29, 2017
clalancette
clalancette reviewed Nov 30, 2017
View reviewed changes
package.xml Outdated
@@ -32,6 +32,8 @@
<test_depend>launch</test_depend>
<test_depend>ros2run</test_depend>

<group_depend>rosidlinterfaces_packages</group_depend>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be rosidl_interfaces_packages

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm Looks like I was unable to type 😖

@mikaelarguedas mikaelarguedas merged commit 3800f29 into master Nov 30, 2017
@mikaelarguedas mikaelarguedas deleted the format3_interface_packages branch November 30, 2017 23:33
@mikaelarguedas mikaelarguedas removed the in progress Actively being worked on (Kanban column) label Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikaelarguedas @clalancette