Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drops legacy launch API usage. #163

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Feb 11, 2019

Connected to ros2/launch#159.

@hidmic hidmic self-assigned this Feb 11, 2019
@tfoote tfoote added the in progress Actively being worked on (Kanban column) label Feb 11, 2019
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic force-pushed the hidmic/drop-legacy-launch branch from 355716b to ecf7808 Compare February 11, 2019 18:09
@cottsay cottsay requested a review from mjcarroll February 22, 2019 19:36
@hidmic hidmic added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Feb 25, 2019
@mjcarroll mjcarroll merged commit 2a891ef into master Feb 27, 2019
@mjcarroll mjcarroll deleted the hidmic/drop-legacy-launch branch February 27, 2019 19:37
@mjcarroll mjcarroll removed the in review Waiting for review (Kanban column) label Feb 27, 2019
dhananjaysathe pushed a commit to rapyuta-robotics/ros1_bridge that referenced this pull request Aug 22, 2019
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Dhananjay Sathe <dhananjay.sathe@rapyuta-robotics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants