Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows propagations of cmd args to rclcpp::init #178

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

gonzodepedro
Copy link
Contributor

Signed-off-by: Gonzalo de Pedro gonzalo@depedro.com.ar

This changes the order of initialization of nodes. By initializing firs the ROS2 node it allows cmd args to be passed to it.

Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
@gonzodepedro gonzodepedro added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) labels Mar 21, 2019
@dirk-thomas
Copy link
Member

How about command line arguments for ROS 1 now?

@gonzodepedro
Copy link
Contributor Author

Command line arguments processing in ROS2 doesn't interfere, it process the ones that understands and doesn't modify the argc and argv. ROS1 command line arguments processing OTH removes arguments from the argv. That's why passing them first to ROS2 and later to ROS1 doesn't affect neither of them, while passing first to ROS1 and then to ROS2 ends up in the arguments for ROS2 being ignored.

@gonzodepedro
Copy link
Contributor Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@gonzodepedro
Copy link
Contributor Author

Linux-aarch64 and Windows CI jobs test failed on test already known to fail, not related to this PR

@gonzodepedro gonzodepedro merged commit dc25bc3 into master Mar 27, 2019
@gonzodepedro gonzodepedro removed in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) labels Mar 27, 2019
@gonzodepedro gonzodepedro deleted the gonzalodepedro/fix-propagate-args-to-rcl-init branch March 27, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants