fix parsing empty string literal #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added
bug
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
force-pushed
the
dirk-thomas/fix-empty-string-literal
branch
from
e57b0d4 to
d7236a9
Compare
jacobperron
reviewed
Sep 9, 2019
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
I added a case for this to the
|
jacobperron
approved these changes
Sep 9, 2019
delete-merged-branch
bot
deleted the
dirk-thomas/fix-empty-string-literal
branch
dirk-thomas
added a commit
that referenced
this pull request
Oct 10, 2019
* fix parsing empty string literal Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * add annotation with empty string literal parameter Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> (cherry picked from commit f445d96)
dirk-thomas
added a commit
that referenced
this pull request
Oct 10, 2019
* fix parsing empty string literal Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * add annotation with empty string literal parameter Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> (cherry picked from commit f445d96)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405.
I am not going to run CI for this since obviously we don't have that case anywhere in the code base atm. Otherwise the following assertion would have failed.