Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pytest.ini so tests succeed locally. #502

Merged
merged 2 commits into from
Jun 25, 2020

Conversation

clalancette
Copy link
Contributor

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

This is part of ros2/ros2#951, which has more explanation and CI.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette force-pushed the clalancette/add-pytest-ini branch from fef9b30 to b6df434 Compare June 25, 2020 12:42
@dirk-thomas
Copy link
Member

Adding the file to the repository root wouldn't work if users only fetch individual packages (e.g. using rosinstall_generator). Therefore I would suggest to add the file to each package which needs it separately.

@clalancette
Copy link
Contributor Author

Adding the file to the repository root wouldn't work if users only fetch individual packages (e.g. using rosinstall_generator). Therefore I would suggest to add the file to each package which needs it separately.

Makes sense, will change it.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette merged commit 651dfd1 into master Jun 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the clalancette/add-pytest-ini branch June 25, 2020 16:57
jacobperron pushed a commit that referenced this pull request Aug 24, 2020
* Add pytest.ini so tests succeed locally.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
jacobperron pushed a commit that referenced this pull request Aug 24, 2020
* Add pytest.ini so tests succeed locally.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants