Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression on nightly builds sros2.src.ros2.sros2.sros2.test.sros2.commands.security.verbs.test_generate_policy.test_generate_policy_services #213

Closed
tfoote opened this issue May 14, 2020 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@tfoote
Copy link
Contributor

tfoote commented May 14, 2020

Bug report

sros2.src.ros2.sros2.sros2.test.sros2.commands.security.verbs.test_generate_policy.test_generate_policy_services is failing on multiple platforms on the nightly builds

Required Info:

Steps to reproduce issue

Run the CI:

sros2.src.ros2.sros2.sros2.test.sros2.commands.security.verbs.test_generate_policy.test_generate_policy_services

Expected behavior

Tests pass

Actual behavior

Tests fail

Additional information

@tfoote tfoote added the bug Something isn't working label May 14, 2020
@ruffsl
Copy link
Member

ruffsl commented May 14, 2020

The stacktrace from the failed test log doesn't seem informative:

test/sros2/commands/security/verbs/test_generate_policy.py:44: in test_generate_policy_topics
    assert cli.main(
E   AssertionError: assert 1 == 0
E    +  where 1 = <function main at 0xffffb1e529d0>(argv=['security', 'generate_policy', '/tmp/tmpi_bj77wj/test-policy.xml'])
E    +    where <function main at 0xffffb1e529d0> = cli.main

Is the python stacktrace being captured correctly?

@tfoote
Copy link
Contributor Author

tfoote commented May 14, 2020

Well it's asserting here:

that the return code is zero so there's not much stack trace. The function has returned 1 already.

@kyrofa
Copy link
Member

kyrofa commented May 14, 2020

We've hit a difference in environment between the nightly tests and the normal ones in the past, could this be related to that?

@tfoote
Copy link
Contributor Author

tfoote commented May 14, 2020

@kyrofa That would be surprising if something like that changed overnight, it's been working up until today.

@hidmic Pointed out to me that this could be related: #212

@sloretz
Copy link
Contributor

sloretz commented Jun 11, 2020

If I understand correctly, @hidmic's PR #214 might fix this

@mikaelarguedas
Copy link
Member

This should be addressed by #214 so I'm going to close this. Feel free to comment here if the issue persists and we can reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants