Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment shows target repo version, not action version #51

Closed
gzaripov opened this issue May 18, 2023 · 5 comments · Fixed by #52
Closed

Comment shows target repo version, not action version #51

gzaripov opened this issue May 18, 2023 · 5 comments · Fixed by #52
Labels
bug Something isn't working

Comments

@gzaripov
Copy link

We have a lot of different tags in our repo using it in documentation preview title is kind of silly. Please add feature to change or remove it, it would make our PR comment much nicer!

Example of how it looks right now:
image
@rossjrw
Copy link
Owner

rossjrw commented May 18, 2023

Oh no! That's not supposed to happen. That's supposed to show the current version of PR Preview Action, not the version of the repository being previewed. Sort of nuts that I missed this. Thanks for raising!

@rossjrw rossjrw added the bug Something isn't working label May 18, 2023
@rossjrw rossjrw changed the title Allow changing the last tag from PR comment title Comment shows target repo version, not action version May 18, 2023
@gzaripov
Copy link
Author

Here are logs with details
image

@gzaripov
Copy link
Author

gzaripov commented May 18, 2023 •
edited
Loading

The same thing when I set the latest version of action explicitly
image

@rossjrw rossjrw mentioned this issue May 18, 2023
Merged
@rossjrw
Copy link
Owner

rossjrw commented May 18, 2023

Thanks @gzaripov. Fixed in v1.4.3

@gzaripov
Copy link
Author

I confirm that fix works! Thank you so much for a quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix action version check rossjrw/pr-preview-action
2 participants
@gzaripov @rossjrw