feat: Add custom color picker #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions for pull request titles! 🙏 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rotimi-best
requested changes
Sep 20, 2024
apps/dashboard/src/app.postcss
Outdated
Comment on lines
206
to
214
| .theme-custom .bg-primary-50 { | ||
| background-color: #fff1f2 !important; | ||
| } | ||
| .theme-custom .text-primary-50 { | ||
| color: #fff1f2 !important; | ||
| } | ||
| .theme-custom .border-primary-50 { | ||
| border-color: #fff1f2 !important; | ||
| } |
There was a problem hiding this comment.
@tunny17 This should probably not be here
There was a problem hiding this comment.
yes, my bad, i'll remove that in this fix i'm about to push
| if (!hex) return; | ||
|
|
||
| // Create a promise that resolves after the delay | ||
| await new Promise((resolve) => setTimeout(resolve, 1000)); |
There was a problem hiding this comment.
We should probably remove this, right?
There was a problem hiding this comment.
honestly, no, whenever that picker gets dragged we update our db so if we remove this and a user drags from point a to b in 10s, we'll be sending 10 requests to supabase so i added this one to make that request on finalize
| .update({ theme: hex }) | ||
| .match({ id: $currentOrg.id }); | ||
|
|
||
| console.log('Update theme', res); |
There was a problem hiding this comment.
Show a snackbar if an error occurs here
apps/dashboard/src/lib/components/Org/Settings/OrgSettings.svelte
Outdated
Show resolved
Hide resolved
…o org-color-picker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (place issue number here without bracket)
Type of change
How should this be tested?
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated