Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added refresh button to generate new slug. #65

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

R4Rohit23
Copy link
Contributor

What does this PR do?

Added refresh button to generate new slug which gives user ability to create desired link for their respective course.

Fixes #56

Result

https://jam.dev/c/06284842-610a-4486-a9ea-74ec8974006e

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the ClassroomIO Docs if changes were necessary

Copy link

vercel bot commented Nov 30, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @rotimi-best on Vercel.

@rotimi-best first needs to authorize it.

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 8:26am

Copy link

github-actions bot commented Nov 30, 2023

Thank you for following the naming conventions for pull request titles! 🙏

@github-actions github-actions bot added the good first issue Good for newcomers label Nov 30, 2023
@R4Rohit23 R4Rohit23 changed the title Added Button to generate new slug. feat - added refresh button to generate new slug. Nov 30, 2023
@R4Rohit23 R4Rohit23 changed the title feat - added refresh button to generate new slug. feat : added refresh button to generate new slug. Nov 30, 2023
@R4Rohit23 R4Rohit23 changed the title feat : added refresh button to generate new slug. feat: added refresh button to generate new slug. Nov 30, 2023
Copy link
Owner

@rotimi-best rotimi-best left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left you a comment.

apps/dashboard/.env.example Outdated Show resolved Hide resolved
Copy link
Owner

@rotimi-best rotimi-best left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is good progress so far. Just one comment left to address

apps/dashboard/.env.example Outdated Show resolved Hide resolved
Copy link
Owner

@rotimi-best rotimi-best left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works pretty fine.

Thank you @R4Rohit23 for this PR, you are the best 😉

@rotimi-best rotimi-best merged commit 29f45f6 into rotimi-best:main Dec 1, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "restart" icon, that when clicked regenerates the slug of a course
2 participants