Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unit tests for utils functions #92

Merged
merged 9 commits into from
Dec 20, 2023

Conversation

Toyin5
Copy link
Contributor

@Toyin5 Toyin5 commented Dec 9, 2023

What does this PR do?

Add unit tests to the project

Fixes #66

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the ClassroomIO Docs if changes were necessary

Copy link

vercel bot commented Dec 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ❌ Failed (Inspect) Dec 20, 2023 11:03am
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2023 11:03am
landingpage ❌ Failed (Inspect) Dec 20, 2023 11:03am

Copy link

vercel bot commented Dec 9, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @rotimi-best on Vercel.

@rotimi-best first needs to authorize it.

Copy link

github-actions bot commented Dec 9, 2023

Thank you for following the naming conventions for pull request titles! 🙏

@rotimi-best
Copy link
Owner

Hi, I have fixed the issue and pushed it to this branch

https://github.com/rotimi-best/classroomio/tree/feature/unittesting

image

@Toyin5 Toyin5 changed the title Addeed unit tests Added unit tests Dec 17, 2023
Copy link
Owner

@rotimi-best rotimi-best left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Toyin5 Thank you for this amazing work 🫡😃.

Just a little more and our utility functions should be ready to go. 🫱🏾‍🫲🏻

apps/dashboard/jest.config.ts Show resolved Hide resolved
apps/dashboard/src/lib/utils/functions/course.spec.ts Outdated Show resolved Hide resolved
apps/dashboard/src/lib/utils/functions/date.spec.ts Outdated Show resolved Hide resolved
@rotimi-best
Copy link
Owner

@Toyin5 It seems like pnpm run prepare is failing, can you please test it locally?

image

@Toyin5 Toyin5 changed the title Added unit tests feat: unit tests Dec 18, 2023
Copy link
Owner

@rotimi-best rotimi-best left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Toyin5 Thank you so much for this work. 🙏 😃

You just need to merge main into your branch and fix any conflicts then I can merge in code 🚀 🚀 🚀 🚀

@rotimi-best rotimi-best merged commit 6d689ed into rotimi-best:main Dec 20, 2023
6 checks passed
@Toyin5 Toyin5 deleted the feature/unittesting branch December 23, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement unit test into the dashboard app
2 participants