Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exercise dates have been fixed #93

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Conversation

shodown96
Copy link
Contributor

@shodown96 shodown96 commented Dec 9, 2023

What does this PR do?

According to the Issue #87: Exercise Date Discrepancy, There was a discrepancy where the exercise dates created were not corresponding with the created date as expected, and this could cause confusion for others in the future.
It will show Today/Tomorrow/Yesterday or the actual date.

Fixes # (issue)
The dates assigned to the exercises now align with the dates on which they were originally created.

Screenshot 2023-12-09 at 6 53 31 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

Log in to your dashboard by clicking and entering your credentials in the email and password fields.
Navigate to the "Courses" feature on your dashboard.
Choose a specific course from your created list.
Select the "Lessons" feature.
Navigate to the exercise section
Observe the exercise date displayed.

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the ClassroomIO Docs if changes were necessary

Copy link

vercel bot commented Dec 9, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @rotimi-best on Vercel.

@rotimi-best first needs to authorize it.

Copy link

vercel bot commented Dec 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2023 6:49pm
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2023 6:49pm
landingpage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2023 6:49pm

Copy link

github-actions bot commented Dec 9, 2023

Thank you for following the naming conventions for pull request titles! 🙏

@rotimi-best
Copy link
Collaborator

@shodown96 Just tested this. Thanks a lot, it works well ☺️😃🚀

Copy link
Collaborator

@rotimi-best rotimi-best left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rotimi-best rotimi-best merged commit 72a024f into classroomio:main Dec 9, 2023
6 of 8 checks passed
@rotimi-best rotimi-best mentioned this pull request Dec 9, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants