Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Corrected Duplicate Response Messages #95

Merged
merged 5 commits into from
Dec 10, 2023

Conversation

topboyasante
Copy link
Contributor

What does this PR do?

This PR Fixes the Duplicate Response Messages on certain actions

Fixes #90

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • To test this, you must run npm run dev or pnpm dev

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the ClassroomIO Docs if changes were necessary

Copy link

vercel bot commented Dec 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2023 10:03am

Copy link

vercel bot commented Dec 10, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @rotimi-best on Vercel.

@rotimi-best first needs to authorize it.

@github-actions github-actions bot added bug Something isn't working good first issue Good for newcomers labels Dec 10, 2023
Copy link

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Collaborator

@rotimi-best rotimi-best left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR Asante 😃.

Looks good to me.

@rotimi-best rotimi-best merged commit 390b8c6 into classroomio:main Dec 10, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate Response Messages
2 participants