Cannot add identities after upgrade to 1.5.0

[reinob]

I just upgraded to 1.5.0 (with the "complete" tarball and running ./bin/installto... as I always do), and noticed that my identities were gone (had only the default one with only the e-mail adress, no name, no organization, etc.).

I could update the default identity, but when I click on the "+" icon to create a new identity, I get

Oops... something went wrong!
An internal error has occurred. Your request cannot be processed at this time.
For administrators: Please check the application and/or server error logs for more information.

In the log the following appears at that (and each) time:

[19-Oct-2021 08:48:04 Europe/Berlin] PHP Fatal error:  Uncaught Error: Unsupported operand types in /var/www/roundcube/plugins/identity_smtp/identity_smtp.php:194
Stack trace:
#0 /var/www/roundcube/program/lib/Roundcube/rcube_plugin_api.php(513): identity_smtp->identityFormWillBeDisplayed()
#1 /var/www/roundcube/program/actions/settings/identity_edit.php(168): rcube_plugin_api->exec_hook()
#2 /var/www/roundcube/program/include/rcmail_output_html.php(1484): rcmail_action_settings_identity_edit::identity_form()
#3 [internal function]: rcmail_output_html->xml_command()
#4 /var/www/roundcube/program/include/rcmail_output_html.php(1322): preg_replace_callback()
#5 /var/www/roundcube/program/include/rcmail_output_html.php(825): rcmail_output_html->parse_xml()
#6 /var/www/roundcube/program/include/rcmail_output_html.php(654): rcmail_output_html->parse()
#7 /var/www/roundcube/program/actions/settings/identity_edit.php(78): rcmail_output_html->send()
#8 /var/www/roundcube/program/include/rcmail.php(275): rcmail_action_settings_identity_edit->run()
#9 /var/www/roundcube/in in /var/www/roundcube/plugins/identity_smtp/identity_smtp.php on line 194

I haven't (yet) looked at the corresponding code (I can more or less read php, but am by no means an expert).
In case it's relevant, I'm using sqlite.

Any ideas?

[alecpl]

You're using an external plugin we do not support.

[reinob]

Oops. I was about to close the ticket myself, because I just realized the reason/cause was the identity_smtp plugin. Thanks.

[mcnesium]

@alecpl is there any chance there will be support for multiple SMTP servers for Roundcube identities any time in the future?

I wonder what the expected default usage scenario for Roundcube is. While it is very easy to have multiple identities including PGP keys and all, there is only one SMTP server for every user with every identity. It is very hard to find a mail provider that has their SMTP server accept random sender addresses, and any properly set up receiving mailserver will reject mails sent via those anyway. So actually it is only possible to use just one mail address with Roundcube properly. Did I miss something?

[protopyte]

For those who ended up here with the same error, here is a fix

[mcnesium]

Thanks for the hint @g00dd00d

Here is how I patched this in my Dockerfile:

# patch identity_smtp according to https://github.com/deflomu/Roundcube-SMTP-per-Identity-Plugin/blob/411a33432ab1ba7fdb6004f6b2b66bd3601dff9f/identity_smtp.php
RUN sed -i "s/\$args\['record'\]/isset(\$args\['record'\]) \? \$args\['record'\] : \[\]/g" /usr/src/roundcubemail/plugins/identity_smtp/identity_smtp.php