fix: don't add to route undefined parameters

router5 · Jan 25, 2016 · 00dd55a · 00dd55a
1 parent daa451d
commit 00dd55a
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 7 deletions.
diff --git a/modules/index.js b/modules/index.js
@@ -1,3 +1,11 @@
+const getDefinedParams = params =>
+    Object.keys(params)
+        .filter(param => params[param] !== undefined)
+        .reduce(
+            (acc, param) => ({ ...acc, [param]: params[param] }),
+            {}
+        );
+
 const persistentParamsPlugin = (params = {}) => router => {
     // Persistent parameters
     const persistentParams = Array.isArray(params)
@@ -14,12 +22,12 @@ const persistentParamsPlugin = (params = {}) => router => {
 
     // Decorators
     router.buildPath = function (route, params) {
-        const routeParams = { ...persistentParams, ...params };
+        const routeParams = { ...getDefinedParams(persistentParams), ...params };
         return buildPath.call(router, route, routeParams);
     };
 
     router.buildState = function (route, params) {
-        const routeParams = { ...persistentParams, ...params };
+        const routeParams = { ...getDefinedParams(persistentParams), ...params };
         return buildState.call(router, route, routeParams);
     };
 

diff --git a/test/main.js b/test/main.js
@@ -21,12 +21,15 @@ describe('router5 persistent params plugin', () => {
 
         it('should persist specified parameters', (done) => {
             router.start();
-            router.navigate('route1', { id: '1', mode: 'dev' }, {}, (err, state) => {
-                expect(state.path).to.equal('/route1/1?mode=dev');
+            router.navigate('route2', { id: '2' }, {}, (err, state) => {
+                expect(state.path).to.equal('/route2/2');
+                router.navigate('route1', { id: '1', mode: 'dev' }, {}, (err, state) => {
+                    expect(state.path).to.equal('/route1/1?mode=dev');
 
-                router.navigate('route2', { id: '2' }, {}, (err, state) => {
-                    expect(state.path).to.equal('/route2/2?mode=dev');
-                    done();
+                    router.navigate('route2', { id: '2' }, {}, (err, state) => {
+                        expect(state.path).to.equal('/route2/2?mode=dev');
+                        done();
+                    });
                 });
             });
         });