Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right click menu for cells #600

Closed
harinij opened this issue Dec 13, 2021 · 3 comments
Closed

Right click menu for cells #600

harinij opened this issue Dec 13, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request job-task

Comments

@harinij
Copy link
Member

harinij commented Dec 13, 2021

Add right click menu for table cells with useful features such as..

copy, paste
copy column name, id, ref

other ideas welcome to discuss

@harinij harinij added enhancement New feature or request job-task labels Dec 13, 2021
@gibsonliketheguitar
Copy link
Contributor

gibsonliketheguitar commented Dec 30, 2021

Should we have a global state in Jotai to store the copying of values?
Edit, should we replicate column menu code, for the right-clicking of cell?

@shamsmosowi
Copy link
Member

hi @gibsonliketheguitar, the copied values should be stored into the clipboard, so users are able to move their data out of rowy.
We should be keeping the same style as the column menu, but no need to include column level functionality included in the column menu already.

@gibsonliketheguitar
Copy link
Contributor

gibsonliketheguitar commented Jan 5, 2022

Opened a PR #621

Was working on this to #622.
In addition, @src200 I notice you wrapped the Row with the ContextMenu.

The potential problem is the unnecessary duplication of ContextMenu on all the
You need one instance of ContextMenu.
My implementation followed the ColumnMenu Code, and used a CellMenuRef to handle the conditional rendering of the ContextMenu

@shamsmosowi @src200 Let's figure out who will be taking this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request job-task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants