Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last.fm integration #32

Open
rrrnld opened this issue Nov 12, 2018 · 5 comments
Open

Last.fm integration #32

rrrnld opened this issue Nov 12, 2018 · 5 comments
Labels
enhancement New feature or request

Comments

@rrrnld
Copy link
Owner

rrrnld commented Nov 12, 2018

I think it makes sense to handle scrobbling completely on the clientside. I created a branch feature/lastfm to track progress on this. The lastfm API is a a bit ugly but it should work. The main reason is that server-side development takes some time and the new rest API will have to be planned carefully.

It still makes sense to leave some logic related to artist information etc. on the server. The good news is that you don't need any authorization for that (see album.getInfo, artist.getInfo and artist.getSimilar). It should be easier to do this scrobbling on the client though, so maybe we can fix airsonic/airsonic#776 and finally close quite a popular issue.

@rrrnld rrrnld added the bug Something isn't working label Nov 12, 2018
@rrrnld rrrnld added enhancement New feature or request and removed bug Something isn't working labels Nov 25, 2018
@rrrnld
Copy link
Owner Author

rrrnld commented Nov 25, 2018

While we're at it, might as well add support for libre.fm. Seems to support the old scrobbling API: https://git.gnu.io/foocorp/librefm/wikis/Librefm_API

@jvoisin
Copy link

jvoisin commented Apr 11, 2019

Please make this easy to disable ♥

@rrrnld
Copy link
Owner Author

rrrnld commented Apr 11, 2019

It would be opt-in, because you need to login to receive a token to submit any kind of scrobble.

@ronilaukkarinen
Copy link
Contributor

+1 for this! I'd help, if I knew more about Clojure.

@ronilaukkarinen
Copy link
Contributor

ronilaukkarinen commented Sep 30, 2019

Not sure if this would help: clojure-lastfm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants