Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rs.utils.compute_structurefactor_multiplicity doesn't account for centering #7

Closed
kmdalton opened this issue Jul 28, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@kmdalton
Copy link
Member

Right now epsilon factors do not account for space group centering. We should change rs.utils.compute_structurefactor_multiplicity to account for the space group centering operations. This is easy enough to implement, but right now our test data for epsilon factors are from sgtbx. It is easily verified that these don't take centering into account.

>>> df = pd.read_csv("tests/data/sgtbx/sgtbx.csv.bz2")
>>> df.groupby('xhm').min()['epsilon'].max()
    1

I propose we modify tests/data/gen_sgtbx_reference_data.sh to use both gemmi and sgtbx for epsilons. When we test against sgtbx, we just have to remember to divide by len(spacegroup.operations().cen_ops) and/or epsilons.min().

@kmdalton kmdalton added the bug Something isn't working label Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants