Fix global leak #174
Merged
Fix global leak #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narcissus_packed.js leaked a global Narcissus (which is not needed in order to function properly.
|
This should just need rubber stamping really, and would make a huge difference to the many people depending on this module. |
|
Thanks 😄 |
|
Published to v0.1.4 |
michaelficarra
pushed a commit
to michaelficarra/js2coffee
that referenced
this pull request
Nov 13, 2013
- [Fixed CoffeeScript version problems](js2coffee#189) - [Use only compatible coffee-script version](js2coffee#196) - [Defines RESERVED words if not defined](js2coffee#194) - Rewrote to only use local coffee-script installation, rather than using global installation - [Fixed global leak](js2coffee#174) - Tests now use the [Joe Test Runner](https://github.com/bevry/joe), instead of using nothing before - Watched, compiled, bundled, and automatically tested with [DocPad](http://docpad.org/) - Added [TravisCI](https://travis-ci.org/) support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
narcissus_packed.js leaks a global Narcissus (which is not needed in order to function properly. This fixes that global leak.