From 222179dea8ddcbdcb7e4783a345f72429baa8deb Mon Sep 17 00:00:00 2001
From: Jon Jaques <jon@jonjaques.com>
Date: Wed, 4 Sep 2013 00:36:15 -0500
Subject: [PATCH] Add support for specifying parent container

---
 nprogress.css     | 10 ++++++++++
 nprogress.js      |  9 ++++++++-
 support/style.css | 12 ++++++++----
 test/test.js      | 21 +++++++++++++++++++++
 4 files changed, 47 insertions(+), 5 deletions(-)

diff --git a/nprogress.css b/nprogress.css
index 21c5fbb..6752d7f 100644
--- a/nprogress.css
+++ b/nprogress.css
@@ -53,6 +53,16 @@
           animation: nprogress-spinner 400ms linear infinite;
 }
 
+.nprogress-custom-parent {
+  overflow: hidden;
+  position: relative;
+}
+
+.nprogress-custom-parent #nprogress .spinner,
+.nprogress-custom-parent #nprogress .bar {
+  position: absolute;
+}
+
 @-webkit-keyframes nprogress-spinner {
   0%   { -webkit-transform: rotate(0deg); }
   100% { -webkit-transform: rotate(360deg); }
diff --git a/nprogress.js b/nprogress.js
index 2d6d590..c0c0497 100644
--- a/nprogress.js
+++ b/nprogress.js
@@ -27,6 +27,7 @@
     showSpinner: true,
     barSelector: '[role="bar"]',
     spinnerSelector: '[role="spinner"]',
+    parent: 'body',
     template: '<div class="bar" role="bar"><div class="peg"></div></div><div class="spinner" role="spinner"><div class="spinner-icon"></div></div>'
   };
 
@@ -226,6 +227,7 @@
 
     var bar      = progress.querySelector(Settings.barSelector),
         perc     = fromStart ? '-100' : toBarPerc(NProgress.status || 0),
+        parent   = document.querySelector(Settings.parent),
         spinner;
     
     css(bar, {
@@ -238,7 +240,11 @@
       spinner && removeElement(spinner);
     }
 
-    document.body.appendChild(progress);
+    if (parent != document.body) {
+      addClass(parent, 'nprogress-custom-parent');
+    }
+
+    parent.appendChild(progress);
     return progress;
   };
 
@@ -248,6 +254,7 @@
 
   NProgress.remove = function() {
     removeClass(document.documentElement, 'nprogress-busy');
+    removeClass(document.querySelector(Settings.parent), 'nprogress-custom-parent')
     var progress = document.getElementById('nprogress');
     progress && removeElement(progress);
   };
diff --git a/support/style.css b/support/style.css
index 3c15363..1a78acf 100644
--- a/support/style.css
+++ b/support/style.css
@@ -3,6 +3,11 @@ i, b {
   font-weight: 400;
 }
 
+body, html {
+  padding: 0;
+  margin: 0;
+}
+
 body {
   background: white;
 }
@@ -130,11 +135,10 @@ button {
 }
 
 .page-header {
-  margin: 1.5em auto;
   text-align: center;
   max-width: 400px;
-  padding: 0 20px;
-  margin: 3em auto;
+  padding: 3em 20px;
+  margin: 0 auto;
 }
 
 .page-header h1 {
@@ -173,7 +177,7 @@ p.brief.big {
   .page-header h1 {
     font-size: 3em; }
   .page-header {
-    margin: 4.5em auto 3.5em auto;
+    padding: 4.5em 20px 3.5em 20px;
   }
 }
 
diff --git a/test/test.js b/test/test.js
index cd8f9dd..bd53cfb 100644
--- a/test/test.js
+++ b/test/test.js
@@ -71,6 +71,14 @@
         NProgress.start();
         assert.equal(NProgress.status, NProgress.settings.minimum);
       });
+
+      it('must be attached to specified parent', function() {
+        var test = $('<div>', {id: 'test'}).appendTo('body');
+        NProgress.configure({parent: '#test'});
+        NProgress.start();
+        assert.isTrue($("#nprogress").parent().is(test));
+        assert.isTrue($(NProgress.settings.parent).hasClass("nprogress-custom-parent"));
+      });
     });
 
     // ----
@@ -91,6 +99,19 @@
 
     // ----
 
+    describe('.remove()', function() {
+      it('should be removed from the parent', function() {
+        NProgress.set(1);
+        NProgress.remove();
+
+        var parent = $(NProgress.settings.parent);
+        assert.isFalse(parent.hasClass('nprogress-custom-parent'));
+        assert.equal(parent.find('#nprogress').length, 0);
+      });
+    })
+
+    // ----
+
     describe('.inc()', function() {
       it('should render', function() {
         NProgress.inc();