Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #206] Fix a false positive for Rails/RakeEnvironment when using Capistrano #207

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

sinsoku
Copy link
Contributor

@sinsoku sinsoku commented Feb 28, 2020

It excludes the directory where Capistrano tasks are located.
Because these tasks don't need to invoke the :environment task, and the directory structure is the official way.
ref: https://github.com/capistrano/capistrano/tree/v3.12.0#capify-your-project

Fixes #206


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic
Copy link
Member

koic commented Feb 28, 2020

CI has failed. Can you run rake generate_cops_documentation and apply it?

…en using Capistrano

It excludes the directory where Capistrano tasks are located.
Because these tasks don't need to invoke the `:environment` task,
and the directory structure is the official way.
ref: https://github.com/capistrano/capistrano/tree/v3.12.0#capify-your-project

Fixes rubocop#206
@sinsoku sinsoku force-pushed the exclude_capistrano_tasks branch from e8c2450 to 4cb5cd5 Compare February 28, 2020 04:10
@sinsoku
Copy link
Contributor Author

sinsoku commented Feb 28, 2020

Oops. I updated doc and force-pushed.

@koic koic merged commit 3dfebcd into rubocop:master Feb 28, 2020
@koic
Copy link
Member

koic commented Feb 28, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/RakeEnvironment false positive when using Capistrano
2 participants