Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Rails/IndexBy and Rails/IndexWith cops #208

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

eugeneius
Copy link
Contributor

Active Support provides Enumerable#index_by, which creates a hash by yielding each element and using the result as the key and the original element as the value, and Enumerable#index_with, which uses the result as the value and the original element as the key.

These cops identify and correct some patterns for doing the same thing using each_with_object, map { ... }.to_h, or Hash[map { ... }].

This is heavily based on @djudd-stripe's work in rubocop/rubocop#7663, adapted to detect the same patterns when called on an enumerable rather than a hash.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Active Support provides `Enumerable#index_by`, which creates a hash by
yielding each element and using the result as the key and the original
element as the value, and `Enumerable#index_with`, which uses the result
as the value and the original element as the key.

These cops identify and correct some patterns for doing the same thing
using `each_with_object`, `map { ... }.to_h`, or `Hash[map { ... }]`.

Co-authored-by: David Judd <djudd@stripe.com>
@koic
Copy link
Member

koic commented Mar 6, 2020

Great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants