Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <> operator to Rails/WhereNot cop. #351

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

Tietew
Copy link
Contributor

@Tietew Tietew commented Sep 9, 2020

SQL standard defines <> as not-equal operator. != is a de facto standard.

cf. https://www.postgresql.org/docs/12/functions-comparison.html
(I'm afraid I have no pointer to SQL standard documentation.)


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@Tietew Tietew force-pushed the add_stdneq_wherenot branch from 2fe695e to ce50087 Compare September 9, 2020 03:52
Copy link
Member

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tietew This looks good to me. Can you rebase with the latest master branch?

@Tietew Tietew force-pushed the add_stdneq_wherenot branch from ce50087 to 1498e47 Compare September 10, 2020 02:29
@Tietew Tietew force-pushed the add_stdneq_wherenot branch from 1498e47 to 9cacaa1 Compare September 10, 2020 02:39
@Tietew
Copy link
Contributor Author

Tietew commented Sep 10, 2020

@koic Rebased!

@koic koic merged commit 119bbaa into rubocop:master Sep 10, 2020
@koic
Copy link
Member

koic commented Sep 10, 2020

@Tietew Thank you!

@Tietew Tietew deleted the add_stdneq_wherenot branch September 10, 2020 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants