Fix EmptyMetadata for splat kwargs #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
commented
Dec 11, 2024
| @@ -21,6 +21,7 @@ class EmptyMetadata < Base | |||
|
|
|||
| def on_metadata(_symbols, hash) | |||
| return unless hash&.pairs&.empty? | |||
| return if hash.children.any?(&:kwsplat_type?) | |||
There was a problem hiding this comment.
|
Thanks, @pirj! |
pirj
force-pushed
the
fix-empty-metadata-for-kwargs-splat
branch
from
379b9fb to
c78cda4
Compare
pirj
force-pushed
the
fix-empty-metadata-for-kwargs-splat
branch
from
c78cda4 to
4832625
Compare
bquorning
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2004, when metadata is detected as empty when it's actually a kwargs splat.
cc @tylerhunt
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).