Invoke RubrikRESTCall #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 4, 2017 09:21
-Update to Submit-Request to not rely on $resrouce object -Added Invoke-RubrikRestCall
chriswahl
reviewed
Oct 4, 2017
| @@ -1,4 +1,4 @@ | |||
| function Submit-Request($uri,$header,$method,$body) | |||
| function Submit-Request($uri,$header,$method = $($resources.Method) ,$body) | |||
There was a problem hiding this comment.
Curious why this change was required?
There was a problem hiding this comment.
Due to the change made to line 15 for the Invoke-WebRequest. The original version was locked into whatever the $resources item was. I needed Submit-Request to not be dependent on the $resources collection (be more generic). However, to maintain the functionality I changed the method to default to $resources.Method .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding function to allow users to make raw API calls to Rubrik. This enables functionality to call API endpoints not yet supported by the module.