Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AtomicReference as in Atomic gem #78

Closed
pitr-ch opened this issue May 14, 2014 · 4 comments
Closed

Add AtomicReference as in Atomic gem #78

pitr-ch opened this issue May 14, 2014 · 4 comments
Labels
enhancement Adding features, adding tests, improving documentation.

Comments

@pitr-ch
Copy link
Member

pitr-ch commented May 14, 2014

Implement simple AtomicReference with locks or possibly merge Atomic gem, came up in #73.

@pitr-ch pitr-ch mentioned this issue May 14, 2014
10 tasks
@chrisseaton
Copy link
Member

I've done a simple mutex version of this in f187c6f so you can start using it. We'll look at using Java primitives (including the new Unsafe.getAndSetObject from Java 8) soon.

I've called this just Atomic for now, as of course it works with all objects. AtomicReference is too long, and AtomicRef isn't very Ruby-like. What do other people think?

@jdantonio
Copy link
Member

@chrisseaton Thank you!

@pitr-ch
Copy link
Member Author

pitr-ch commented May 15, 2014

@chrisseaton Thanks! I know I am a rookie here, but please open these as PRs next time. It's much easier to discuss the changes then. I'll add comments to the commit.

@jdantonio
Copy link
Member

Now that we have an initial implementation and are working on a plan to merge the ruby-atomic gem, I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding features, adding tests, improving documentation.
Projects
None yet
Development

No branches or pull requests

3 participants